Modify

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#13268 closed defect (worksforme)

Comment on implementation

Reported by: Ryan J Ollos Owned by: Cauly
Priority: normal Component: TracUserSelectFieldPlugin
Severity: normal Keywords:
Cc: Trac Release:

Description (last modified by Ryan J Ollos)

I looked through the source for the plugin and did some testing, just generally curious of what features Trac is lacking that make the plugin necessary. I do this for lots of plugins, so this isn't meant to be critical of the implementation.

Looks like it could be implemented with the following features:

Just using AdvancedTicketWorkflowPlugin eliminates about half the plugin code: t13268.diff.

[ticket]
workflow = ConfigurableTicketWorkflow, TicketWorkflowOpOwnerField

[ticket-workflow]
reassign2 = new,assigned,accepted,reopened -> assigned
reassign2.operations = set_owner_to_field
reassign2.set_owner_to_field = project_usera

Attachments (1)

t13268.diff (2.4 KB) - added by Ryan J Ollos 2 years ago.

Download all attachments as: .zip

Change History (5)

Changed 2 years ago by Ryan J Ollos

Attachment: t13268.diff added

comment:1 Changed 2 years ago by Ryan J Ollos

Description: modified (diff)
Resolution: worksforme
Status: newclosed

comment:2 Changed 2 years ago by Cauly

This plugin is more a technical-validation for me. The two mian functions both uses a 'patch-style' method rather than normal plugin-style method in the implementation. This method is proved to be working, but It may cause unknown influence to other plugins.

Personally I do not recommand others to use this plugin in production. I wrote a notice on the wiki. If you think it's a serious problem, please feel free to remove this plugin.

comment:3 Changed 2 years ago by Ryan J Ollos

I don't think it's a serious problem, but I think it's generally preferable to only have supported and recommended plugins on trac-hacks.org. I've been removing older plugins lately when the author is no longer around and the plugin is broken, there's a better option, or could cause problems if it's installed. I'll leave the final decision to you as to whether to remove this one.

comment:4 Changed 2 years ago by Cauly

Got it.

Since I put a notice on the wiki and there's no replacement for the user-selection part, I choose not to delete for the time being. If you got know any plugins or trac upgraded to support this function, then it's ok to remove this plugin.

However, I seriously doubt that is there a way to implement this function in normal way, since I considered a long time and finally have no choice but to use this ungraceful implemetation.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Cauly.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.