Non-ASCII characters in messages are handled incorrectly

[f.poloni@…]

The plugin fails to send notifications in the case when the ticket summary contains non-ASCII characters.

INotificationFormatter.format produces a bytestring (because it is meant to be sent via e-mail, I presume), which cannot be inserted into the database directly (and the DB insertion in OnSiteMessage.add fails).

[anonymous]

Quick fix:

--- a/plugins-source/onsitenotificationsplugin/onsitenotifications/model.py
+++ b/plugins-source/onsitenotificationsplugin/onsitenotifications/model.py
@@ -45,7 +45,12 @@ class OnSiteMessage(object):
 
     @classmethod
     def add(cls, env, sid, authenticated, message, realm, target):
-        with env.db_transaction as db:
+    	# message is a str (because it is meant to be sent as e-mail)
+    	# but it may contain unicode characters, so we need to convert it
+    	# to the proper encoding before inserting it into the db
+    	if isinstance(message, str):
+    		message = message.decode('utf-8')
+    	with env.db_transaction as db:
             db("""
                 INSERT INTO onsitenotification (sid, authenticated, message,
                                                 realm, target)
-- 

[Peter Suter]

Is this still a problem with the latest version of the plugin? It seems like a duplicate of #13196. Please reopen otherwise.