Symbol markup cannot be escaped

[Ryan J Ollos]

See ​TracDev/Proposals/VerticalHorizontalParsing@4.

The transformation of (C) to the copyright symbol can't be escaped using !(C).

[Jun Omae]

The result of prepare_regexp should be enclosed with (?: and ) but missing parentheses in tracwikiextras/symbols.py.

$ git grep 'prepare_regexp(' -- '*.py'
tracwikiextras/icons.py:            yield (r"(?<!\w)!?(?:%s)" % prepare_regexp(self.smileys),
tracwikiextras/phrases.py:        yield ('!?(?:%s)' % prepare_regexp(self.text), self._format_phrase)
tracwikiextras/symbols.py:            yield ('!?%s' % prepare_regexp(self.symbols), self._format_symbol)
tracwikiextras/util.py:def prepare_regexp(d):

wikiextrasplugin/trunk/tracwikiextras/symbols.py

@@ -119 +119 @@
                     del self.symbols[keyword]
 
         if self.symbols:
-            yield ('!?%s' % prepare_regexp(self.symbols), self._format_symbol)
+            yield ('!?(?:%s)' % prepare_regexp(self.symbols),
+                   self._format_symbol)
         else:
             yield (None, None)
 

[Ryan J Ollos]

Thanks. If you can commit the change, I will go ahead and update the plugin on t.e.o.

[Jun Omae]

In 17307:

TracWikiExtras 1.3.1dev: fix unable to escape symbol markups (closes #13497)