Modify

Opened 3 years ago

Closed 3 years ago

#13526 closed task (wontfix)

PEP-008

Reported by: sbouwhuis Owned by: Geert
Priority: normal Component: WantedPagesMacro
Severity: normal Keywords: PEP
Cc: Trac Release:

Description

PEP-008 update.

Attachments (1)

macro_patch.diff (2.8 KB) - added by sbouwhuis 3 years ago.
macro.py PEP-008 update

Download all attachments as: .zip

Change History (3)

Changed 3 years ago by sbouwhuis

Attachment: macro_patch.diff added

macro.py PEP-008 update

comment:1 Changed 3 years ago by Ryan J Ollos

Please use the unified diff format (see trac:TracDev/SubmittingPatches).

  • db -> d_b is not a good replacement. You'll find hundreds of uses of db in plugins and I've never once seen d_b used.
  • The coding: utf-8 line should not be modified - it has a specific format that is parsed by the interpreter.
  • # should be used for comments rather than triple quotes.

PEP8 changes are usually best done using a tool like pypi:autopep8, rather than manual edits.

comment:2 Changed 3 years ago by Ryan J Ollos

Resolution: wontfix
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Geert.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.