Modify

Opened 8 months ago

Closed 7 months ago

#13525 closed enhancement (fixed)

Provide manual addition of further tickets

Reported by: Marcel Gestewitz Owned by: lucid
Priority: normal Component: PageTicketsMacro
Severity: normal Keywords:
Cc: Trac Release:

Description

Since the PageTickets macro is related to the TicketQuery it would be a nice feature if the macro allows the manual entry of further ticket number as argument.

This is of interest for the case that someone wants to refer to further tickets which are not listed somewhere else in the text.

I managed this by append passed ticket to those which were found with the regular expression:

...
args, kw = parse_args(content)
if kw.has_key('id'):
        tickets.append(kw['id'])
if not tickets:
        return 'No tickets found'
...

Now it is possible to pass ticket number as id, similar to the TicketQuery. Those are listed as union with the tickets referenced somewhere else in text.

Attachments (0)

Change History (4)

comment:1 Changed 8 months ago by Marcel Gestewitz

Summary: Provide manual addtion of further ticketsProvide manual addition of further tickets

comment:2 Changed 8 months ago by clemens

As I understand the proposal would allow to optionally pass one or more ticket number(s) to the macro e.g. [[PageTickets(id=12|34|56)]]. And since the PageTicketsMacro is based on the powerful TicketQuery macro the result would be a union of the manually listed tickets plus those from the PageTickets search result.

The feature can be useful in those cases where the PageTicketsMacro is unable to automatically find the ticket number(s).

comment:3 Changed 7 months ago by lucid

Thanks for the suggestion!

For further suggestions, it would be helpful to get suggested code changes in standard patch format. Please refer to t:TracDev/SubmittingPatches#Makethepatch for information how to do this. It helps to avoid confusion and unambiguously make clear your suggestion. I'm not 100% sure how exactly you intended to change the code, and had to postpone applying the changes until I had more time to fully analyze, reverse engineer and test everything. So investing a bit of time here will help a quicker turnaround for your suggestions.

comment:4 Changed 7 months ago by lucid

Resolution: fixed
Status: newclosed

In 17330:

PageTicketsMacro: Don't ignore explicit additional id=... arguments (fix #13525)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain lucid.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.