Announcer: Preferences trigger ValueError: too many values to unpack

[anonymous]

With Trac version 1.2.5 if a logged-in user clicks on Preferences and then either on Announcements or subscriptions the following error occurs:

Trac detected an internal error: ValueError: too many values to unpack

File "/usr/lib/python2.7/dist-packages/trac/web/main.py", line 647, in _dispatch_request
  dispatcher.dispatch(req)
File "/usr/lib/python2.7/dist-packages/trac/web/main.py", line 248, in dispatch
  resp = chosen_handler.process_request(req)
File "/usr/lib/python2.7/dist-packages/trac/prefs/web_ui.py", line 112, in process_request
  chosen_provider.render_preference_panel(req, panel_id)

[anonymous]

With the attached patch file the error is fixed for me.

[Ryan J Ollos]

In 17660:

TracAnnouncer 1.2.0dev: Make prefs compatible with Trac 1.2

Refs #12120, Fixes #13733.

[Ryan J Ollos]

Work is needed in #12120 to make TracAnnouncer fully compatible with Trac 1.2.

[anonymous]

Sorry, but your latest modification contains a syntax error:

  File "/usr/local/lib/python2.7/site-packages/announcer/pref.py", line 195
    def filter_stream(self, req, method, filename, stream, data):
      ^
SyntaxError: invalid syntax (pref.py, line 195)

The attached file fix_pref_syntax_error.diff solves this issue.

[Ryan J Ollos]

In 17678:

TracAnnouncer 1.2.0dev: Fix syntax error in r17660

Refs #12120, Fixes #13733.