Modify

Opened 2 years ago

Closed 2 years ago

#13733 closed defect (fixed)

Announcer: Preferences trigger ValueError: too many values to unpack

Reported by: anonymous Owned by: Ryan J Ollos
Priority: normal Component: AnnouncerPlugin
Severity: normal Keywords:
Cc: Trac Release:

Description

With Trac version 1.2.5 if a logged-in user clicks on Preferences and then either on Announcements or subscriptions the following error occurs:

Trac detected an internal error: ValueError: too many values to unpack

File "/usr/lib/python2.7/dist-packages/trac/web/main.py", line 647, in _dispatch_request
  dispatcher.dispatch(req)
File "/usr/lib/python2.7/dist-packages/trac/web/main.py", line 248, in dispatch
  resp = chosen_handler.process_request(req)
File "/usr/lib/python2.7/dist-packages/trac/prefs/web_ui.py", line 112, in process_request
  chosen_provider.render_preference_panel(req, panel_id)

Attachments (2)

fix_preferences.diff (688 bytes) - added by anonymous 2 years ago.
fix_pref_syntax_error.diff (470 bytes) - added by anonymous 2 years ago.

Download all attachments as: .zip

Change History (7)

Changed 2 years ago by anonymous

Attachment: fix_preferences.diff added

comment:1 Changed 2 years ago by anonymous

With the attached patch file the error is fixed for me.

comment:2 Changed 2 years ago by Ryan J Ollos

Owner: set to Ryan J Ollos
Resolution: fixed
Status: newclosed

In 17660:

TracAnnouncer 1.2.0dev: Make prefs compatible with Trac 1.2

Refs #12120, Fixes #13733.

comment:3 Changed 2 years ago by Ryan J Ollos

Work is needed in #12120 to make TracAnnouncer fully compatible with Trac 1.2.

Changed 2 years ago by anonymous

Attachment: fix_pref_syntax_error.diff added

comment:4 Changed 2 years ago by anonymous

Resolution: fixed
Status: closedreopened

Sorry, but your latest modification contains a syntax error:

  File "/usr/local/lib/python2.7/site-packages/announcer/pref.py", line 195
    def filter_stream(self, req, method, filename, stream, data):
      ^
SyntaxError: invalid syntax (pref.py, line 195)

The attached file fix_pref_syntax_error.diff solves this issue.

comment:5 Changed 2 years ago by Ryan J Ollos

Resolution: fixed
Status: reopenedclosed

In 17678:

TracAnnouncer 1.2.0dev: Fix syntax error in r17660

Refs #12120, Fixes #13733.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.