Modify

Opened 3 years ago

Last modified 5 weeks ago

#12120 accepted enhancement

Trac 1.2.1 compatibility

Reported by: Peter Suter Owned by: Ryan J Ollos
Priority: normal Component: AnnouncerPlugin
Severity: normal Keywords:
Cc: Steffen Hoffmann, Jun Omae Trac Release: 1.2

Description

Trac 1.1.3 will contain a new notification system (in large parts based on ideas, design and code from Announcer).

However it does not integrate or replace Announcer as a whole. Future versions of Announcer would ideally be compatible with this new notification system and base the additional features that remain unavailable in Trac core on top of the new core infrastructure.

Future versions of Announcer could also provide upgrade paths from older versions of the plugin to the new core infrastructure.

Attachments (1)

Announcer-get_db_cnx_patch.diff (15.3 KB) - added by morgana2313 12 months ago.

Download all attachments as: .zip

Change History (20)

comment:1 Changed 2 years ago by Ryan J Ollos

Cc: Steffen Hoffmann added
Owner: changed from Steffen Hoffmann to Ryan J Ollos
Status: newassigned

Development of AnnouncerPlugin has stalled for many years. I don't have much hope for a utopian future in which a backwards-compatible version of AnnoncerPlugin is created that also works with Trac 1.2. If you have such near-future intentions, please comment. Otherwise, I'm going to move forward with a Trac 1.2 compatible version of AnnouncerPlugin. I would rather look to the future than worry about making AnnouncerPlugin work with old versions of Trac.

What I may try to do however is make a final release of AnnouncerPlugin that is compatible with Trac 1.0, prior to hacking out the components that have been integrated into Trac. It might be easier from a development standpoint to make the current codebase a bit more stable before trying to make it work with Trac 1.2. There are currently 124 open tickets, so this is going to take a fair bit of effort.

Last edited 2 years ago by Ryan J Ollos (previous) (diff)

comment:2 Changed 12 months ago by Ryan J Ollos

Owner: Ryan J Ollos deleted
Status: assignednew

comment:3 Changed 12 months ago by Ryan J Ollos

#12982 closed as a duplicate.

comment:4 Changed 12 months ago by Ryan J Ollos

Owner: set to Ryan J Ollos
Status: newaccepted

comment:5 Changed 12 months ago by Ryan J Ollos

In 16128:

1.0dev: Remove compatibility code and conform to PEP8

Refs #12120.

comment:6 Changed 12 months ago by Ryan J Ollos

In 16129:

1.2dev: Branch for Trac 1.0

The trunk supports Trac 1.2 and later.

Refs #12120.

Changed 12 months ago by morgana2313

comment:7 Changed 12 months ago by morgana2313

Patch that replaces get_db_cnx calls: attachment:Announcer-get_db_cnx_patch.diff

comment:8 Changed 12 months ago by Ryan J Ollos

I thought I'd committed 1.2-compatible changes already, but I see they are still sitting in my working copy. I will review working copy changes and commit soon.

comment:9 Changed 11 months ago by Jun Omae

#13034 was closed as a duplicate.

comment:10 Changed 9 months ago by Ryan J Ollos

Summary: Trac 1.1.3 compatibilityTrac 1.2.1 compatibility

There have been some significant changes for Trac 1.2.1 (e.g. trac:#11928), so I'll probably target compatibility with that version.

comment:11 Changed 8 weeks ago by Ryan J Ollos

In 16893:

TracAnnouncer 1.2.0dev: Use Trac 1.2 API

The plugin is loading and basic functionality is working
when the Trac notification system is disabled. Some of the
optional components may not yet be functional.

This is incremental progress towards removing the components
that have been added to Trac in release 1.2.

Refs #12120.

comment:12 Changed 8 weeks ago by Ryan J Ollos

In 16894:

TracAnnouncer 1.2.0dev: Use datetime_now

Refs #12120.

comment:13 Changed 8 weeks ago by Ryan J Ollos

In 16895:

TracAnnouncer 1.2.0dev: Remove backward-compatible imports

Refs #12120.

comment:14 Changed 8 weeks ago by Ryan J Ollos

In 16896:

TracAnnouncer 1.2.0dev: Replace istrue with as_bool

Refs #12120.

comment:15 Changed 8 weeks ago by Ryan J Ollos

In 16897:

TracAnnouncer 1.2.0dev: Remove empty directories

Refs #12120.

comment:16 Changed 8 weeks ago by Ryan J Ollos

In 16898:

TracAnnouncer 1.2.0dev: Fix incorrect imports

Refs #12120.

comment:17 Changed 8 weeks ago by Ryan J Ollos

In 16899:

TracAnnouncer 1.2.0dev: Use IEmailSenders from Trac

Refs #12120.

comment:18 Changed 8 weeks ago by Jun Omae

Cc: Jun Omae added

Keeping this ticket on my radar because I use Trac 1.0.x and patched AnnouncerPlugin (trunk@r12503) on production environment.

comment:19 Changed 5 weeks ago by Ryan J Ollos

In 16900:

TracAnnouncer 1.2.0dev: Use IEmailAddressResolver from Trac 1.2

Refs #12120.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as accepted The owner will remain Ryan J Ollos.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.