Fails with 1.4.1

[laszlo.elbert@…]

Dear Colleagues, When enabled under 1.4,

Trac Error

TracError: Unable to check for upgrade of privatecomments.privatecomments.PrivateComments: TypeError: environment_needs_upgrade() takes exactly 2 arguments (1 given)
trac-admin upgrade also fails.
trac.log:
 Trac[env] ERROR: Component <Component privatecomments.privatecomments.PrivateComments> failed with
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/trac/env.py", line 387, in component_guard
    yield
  File "/usr/local/lib/python2.7/dist-packages/trac/env.py", line 750, in needs_upgrade
    if participant.environment_needs_upgrade():
TypeError: environment_needs_upgrade() takes exactly 2 arguments (1 given)
2020-04-06 22:34:35,628 Trac[env] ERROR: Exception caught while checking for upgrade: TracError: Unable to check for upgrade of privatecomments.privatecomments.PrivateComments: TypeError: environment_needs_upgrade() takes exactly 2 arguments (1 given)

[Ryan J Ollos]

In 17690:

TracPrivateComments 0.5dev: Branch for Trac 1.4 support

Refs #13776.

[Ryan J Ollos]

Will fix this evening.

[Ryan J Ollos]

The Genshi template modifications need to be ported to JavaScript. It will take a bit longer than I expected.

[Ryan J Ollos]

Some changes to Trac will be needed (​trac:#13282) in order to implement this permission policy.

[Ryan J Ollos]

In 17721:

TracPrivateComments 0.5dev: Remove obsolete files

Refs #13776.

[Ryan J Ollos]

The changes I've prepared filter recipients for notification emails (#7349). I've continued to iterate and make changes will working on ​trac:#13282. After the changes for ​trac:#13282 are complete I'll commit the changes for TracPrivateComments. It will be at least a few weeks before this is ready.