Modify ↓

Opened 5 years ago

Last modified 10 months ago

#13776 accepted defect

Fails with 1.4.1

Reported by: laszlo.elbert@… Owned by: Ryan J Ollos
Priority: normal Component: PrivateCommentPlugin
Severity: normal Keywords:
Cc: virginia.alcaide@…, dmulerom@… Trac Release: 1.4

Description (last modified by Ryan J Ollos)

Dear Colleagues, When enabled under 1.4, 

Trac Error

TracError: Unable to check for upgrade of privatecomments.privatecomments.PrivateComments: TypeError: environment_needs_upgrade() takes exactly 2 arguments (1 given)
trac-admin upgrade also fails.
trac.log:
 Trac[env] ERROR: Component <Component privatecomments.privatecomments.PrivateComments> failed with
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/trac/env.py", line 387, in component_guard
    yield
  File "/usr/local/lib/python2.7/dist-packages/trac/env.py", line 750, in needs_upgrade
    if participant.environment_needs_upgrade():
TypeError: environment_needs_upgrade() takes exactly 2 arguments (1 given)
2020-04-06 22:34:35,628 Trac[env] ERROR: Exception caught while checking for upgrade: TracError: Unable to check for upgrade of privatecomments.privatecomments.PrivateComments: TypeError: environment_needs_upgrade() takes exactly 2 arguments (1 given)

Attachments (0)

Change History (12)

comment:1 Changed 5 years ago by Ryan J Ollos

Description: modified (diff)

comment:2 Changed 5 years ago by Ryan J Ollos

In 17690:

TracPrivateComments 0.5dev: Branch for Trac 1.4 support

Refs #13776.

comment:3 Changed 5 years ago by Ryan J Ollos

Owner: changed from Michael Henke to Ryan J Ollos
Status: new → accepted

Will fix this evening.

comment:4 Changed 5 years ago by Ryan J Ollos

Summary: PrivateCommenst fails with 1.4.1 → Fails with 1.4.1

comment:5 Changed 5 years ago by Ryan J Ollos

The Genshi template modifications need to be ported to JavaScript. It will take a bit longer than I expected.

comment:7 Changed 5 years ago by Ryan J Ollos

Some changes to Trac will be needed (​trac:#13282) in order to implement this permission policy.

Last edited 5 years ago by Ryan J Ollos (previous) (diff)

comment:8 Changed 5 years ago by Ryan J Ollos

In 17721:

TracPrivateComments 0.5dev: Remove obsolete files

Refs #13776.

comment:9 Changed 5 years ago by Ryan J Ollos

The changes I've prepared filter recipients for notification emails (#7349). I've continued to iterate and make changes will working on ​trac:#13282. After the changes for ​trac:#13282 are complete I'll commit the changes for TracPrivateComments. It will be at least a few weeks before this is ready.

comment:10 Changed 5 years ago by Ryan J Ollos

Status: accepted → new

comment:11 Changed 4 years ago by Virginia <virginia.alcaide@…>

Cc: virginia.alcaide@… added

comment:12 Changed 10 months ago by Ryan J Ollos

Status: new → accepted

comment:13 Changed 10 months ago by Ryan J Ollos

Cc: dmulerom@… added

Modify Ticket

Change Properties
Set your email in Preferences
Action
as accepted The owner will remain Ryan J Ollos.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.