Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#13840 closed enhancement (fixed)

Remove Genshi for Trac 1.4 and later

Reported by: Cinc-th Owned by: Cinc-th
Priority: normal Component: SimpleMultiProjectPlugin
Severity: normal Keywords:
Cc: Trac Release: 1.4

Description

Genshi is deprecated and will be removed with Trac 1.6.

This Ticket will track changes made to remove Genshi from the plugin for Trac 1.4+.

Note that the plugin will remain compatible with at least Trac 1.2.

Attachments (0)

Change History (18)

comment:1 Changed 4 years ago by Cinc-th

Owner: set to Cinc-th
Status: newaccepted

comment:2 Changed 4 years ago by Cinc-th

In 17789:

SimpleMultiProjectPlugin: use Jinja2 template for admin page with Trac 1.4.

Refs #13840

comment:3 Changed 4 years ago by Ryan J Ollos

See also #13712.

comment:4 Changed 4 years ago by Cinc-th

In 17792:

SimpleMultiProjectPlugin: no longer use ITemplateStreamFilter for Timeline page. Remove its usage for component SmpRoadmapProjectFilter.
Added some test cases for checking project select control used in preferences panes.

Refs #13840

While at it:

  • Project selection on Timeline page always overwrote Roadmap preferences.
  • Roadmap selection was applied to Timeline page

Possibly Refs #13712.

comment:5 Changed 4 years ago by Cinc-th

In 17793:

SimpleMultiProjectPlugin: superflous import removed in timeline.py. Follow-up to [17792].

Refs #13840

comment:6 Changed 4 years ago by Ryan J Ollos

Do you have a PyPI account? I can add you as a maintainer for pypi:TracSimpleMultiProject.

comment:7 in reply to:  6 ; Changed 4 years ago by Cinc-th

Replying to Ryan J Ollos:

Do you have a PyPI account? I can add you as a maintainer for pypi:TracSimpleMultiProject.

No PyPi for me atm. But you may set me as maintainer for the plugin here at Trac-Hacks so people don't think it is abandoned.

comment:8 Changed 4 years ago by Cinc-th

In 17794:

SimpleMultiProjectPlugin: no longer use ITemplateStreamFilter and Genshi templates when creating or editing milestones from the Roadmap page.
Fixed some bugs with disabling submit buttons while at it.

Refs #13840

comment:9 in reply to:  7 Changed 4 years ago by Ryan J Ollos

Replying to Cinc-th:

No PyPi for me atm. But you may set me as maintainer for the plugin here at Trac-Hacks so people don't think it is abandoned.

Done. Let me know when you get ready to publish a new version.

comment:10 Changed 4 years ago by Cinc-th

In 17795:

SimpleMultiProjectPlugin: no longer use ITemplateStreamFilter and Genshi for adding new project column to components table on main component admin page.
Same for project tables on component admin pages for adding components to projects.

Refs #13840

comment:11 Changed 4 years ago by Cinc-th

In 17796:

SimpleMultiProjectPlugin: no longer use ITemplateStreamFilter and Genshi for adding new project column to version table on main version admin page.
Same for project tables on version admin pages for adding version to projects.

Refs #13840

comment:12 Changed 4 years ago by Cinc-th

In 17798:

SimpleMultiProjectPlugin: no longer use ITemplateStreamFilter and Genshi for adding new project column to milestone table on main milestone admin page.
Same for project tables on milestone admin pages for adding milestone to projects.

Refs #13840

comment:13 Changed 4 years ago by Cinc-th

In 17799:

SimpleMultiProjectPlugin: some refactoring and clean up of filter components for milestone, version and component pages.

Refs #13840

comment:14 Changed 4 years ago by Cinc-th

In 17835:

SimpleMultiProjectPlugin: use Jinja template for project admin page when using Trac 1.4+.

Refs #13840

comment:15 Changed 4 years ago by Cinc-th

In 17841:

SimpleMultiProjectPlugin: move insertion of Group by Project checkbox for roadmap page from filter_stream() to post_process_request().

Refs #13840

comment:16 Changed 4 years ago by Cinc-th

In 17845:

SimpleMultiProjectPlugin: no longer use filter_stream() for project grouping on roadmap page.

Refs #13840

comment:17 Changed 4 years ago by Cinc-th

Resolution: fixed
Status: acceptedclosed

In 17847:

SimpleMultiProjectPlugin: use Jinja2 template for project grouping on roadmap page.

Closes #13840

comment:18 Changed 4 years ago by Cinc-th

In 17848:

SimpleMultiProjectPlugin: fix testcases using a component now gone.

Refs #13840

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Cinc-th.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.