Opened 4 years ago

Closed 8 months ago

#13876 closed enhancement (fixed)

[PATCH] Support Jinja2 Templates

Reported by: anonymous Owned by: Dirk Stöcker
Priority: normal Component: TracIniAdminPanelPlugin
Severity: normal Keywords: patch
Cc: Trac Release: 1.4


I was interested in this plugin, so I tried to convert it to Jinja. I am getting so many requests for Trac changes that it seemed like using this plugin might be a good idea.

I haven't used it before, so I may not be familiar with everything it does. However, basic functions seem OK-ish. At least this is something someone else with more knowledge could take forward.

I don't know how to do the internationalization, so I totally left that out of the new template.

There is a bunch of pre-processing of the data structures in to make up for the list comprehensions used in Genshi. It seems those don't translate to Jinja2. I didn't test that part of the code extensively, and I don't know what kind of oddities could be introduced if it weren't entirely correct. See the code where the comment is: "Pre-process lists for the (Jinja) template"

One general thing I don't quite understand ... I have two inherited files in one of my projects, and you would think the second file would take precedence, but this plugin shows the value from the first one. (e.g. authz_module_name) if it exists in both. However, I don't believe that's an artifact of the Jinja port.

Attachments (1)

traciniadminpanelplugin_jinja_templates.patch (21.2 KB) - added by anonymous 4 years ago.
Patch for use of Jinja templates.

Download all attachments as: .zip

Change History (2)

Changed 4 years ago by anonymous

Patch for use of Jinja templates.

comment:1 Changed 8 months ago by Dirk Stöcker

Resolution: fixed
Status: newclosed

Aaargh. Never got the mail. Now I converted it myself for 1.6.

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Dirk Stöcker.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.