Opened 3 months ago

Closed 3 months ago

Can add tags to tickets but not wiki pages in Trac 1.2; deprecated reference to ipnr was removed in 1.3.1

Reported by: Owned by: Chad Trytten Ryan J Ollos high TagsPlugin blocker 1.4

Description

After upgrading to Trac 1.4, was no longer able to add new tags to wiki pages, even though there was no (noticeable) impact to usage regarding tickets. When the lack of tag addition to wiki pages became a blocker, followed the trace (see below) to tractags/wiki.py through some manual searching through the tagsplugin code to find the offending function call; it was on line 158. Per inline comments found within this changeset from the main trac trunk, "ipnr is deprecated and will be removed in 1.3.1". This submission is provided as an immediate bug (with fix) prior to any proper inspection about how best - or if it's already been done on a branch - to remove the references of ipnr from the tagsplugin code. As a breakfix action, it's possible to simply remove the reference to ipnr from the function signature and resolve the blocking issue. CAVEAT: Downstream effects of this solution (rather than providing a default value if not present) are unknown, but didn't want to spend the time determine valid states or recommended compliance treatment for ipnr since it's a deprecated variable. Further investigation required to fully migrate away from other uses of the no-longer-present ipnr that are still present in tagsplugin source files.

Trac[env] ERROR: Component <Component tractags.wiki.WikiTagInterface> failed with
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/trac/env.py", line 387, in component_guard
yield
File "/usr/local/lib/python2.7/dist-packages/trac/wiki/model.py", line 183, in save
author)
TypeError: wiki_page_changed() takes exactly 7 arguments (6 given) at /usr/local/lib/python2.7/dist-packages/trac/env.py, line = 395


comment:1 Changed 3 months ago by Ryan J Ollos

Status: new → accepted

comment:2 Changed 3 months ago by Ryan J Ollos

In 17952:

TracTags 0.12dev: Remove deprecated ipnr

Refs #13932.

comment:3 Changed 3 months ago by Ryan J Ollos

Resolution: → fixed accepted → closed

Thanks for the report. I think it's working now. The styling is bad, but that will be resolved in #13814.

Modify Ticket

Change Properties