Modify

Opened 9 months ago

Closed 9 months ago

Last modified 9 months ago

#13931 closed task (fixed)

make compatible with Trac 1.4

Reported by: clemens Owned by: Ryan J Ollos
Priority: normal Component: RoadmapPlugin
Severity: normal Keywords:
Cc: Trac Release: 1.4

Description

The RoadmapPlugin 0.4.1 (source:roadmapplugin/trunk@11241​) works well with Trac 1.2. I like it and am using it since years.

But it is not compatible with Trac 1.4.

Error message is as follows:

2021-01-01 00:44:55,333 Trac[env] INFO: -------------------------------- environment startup [Trac 1.4.2] --------------------------------
2021-01-01 00:44:55,368 Trac[loader] ERROR: Skipping "roadmapplugin = roadmapplugin": ImportError: No module named genshi.filters

Obviously this has todo with Genshi being obsolete in Trac 1.4.

It would be nice if this plugin could run also with Trac 1.4. Especially I like the option to sort milestones in ascending / descending order and the option to view all the milestone descriptions directly in the milestone list.

Attachments (0)

Change History (8)

comment:2 Changed 9 months ago by Ryan J Ollos

Owner: changed from Franz to Ryan J Ollos
Status: newaccepted

comment:3 Changed 9 months ago by Ryan J Ollos

In 17947:

Make compatible with Trac 1.4

Refs #13931.

comment:4 Changed 9 months ago by Ryan J Ollos

I think it's working now. Could you test?

comment:5 in reply to:  4 Changed 9 months ago by clemens

Replying to Ryan J Ollos:

[17947] I think it's working now. Could you test?

Yes, RoadmapPlugin version 0.4.2 [17947] works with TRAC 1.4.2.

But in the log there is this warning about Genshi still being used in this plugin. Is this intended?

2021-01-03 11:22:06,220 Trac[env] INFO: environment startup [Trac 1.4.2] --------------------------------
2021-01-03 11:22:35,790 Trac[chrome] WARNING: Component FilterRoadmap relies on deprecated Genshi stream filtering 

I now found out that also the old plugin version 0.4.1 (source:roadmapplugin/trunk@11241) works with TRAC 1.4.2. In my earlier experiments I had not installed Genshi in my Trac 1.4.2, which is why the old plugin 0.4.1 did not work.

As soon as I uninstall Genshi (just for experiment) neither the old plugin version 0.4.1 [11241] nor the new plugin version 0.4.2 [17947] will work.

comment:6 Changed 9 months ago by Ryan J Ollos

Thanks. The Genshi code will need to be replaced with Jinja2 or JavaScript before the plugin will be compatible with Trac 1.5.1 or later, which is the reason for the warning.

comment:7 Changed 9 months ago by Ryan J Ollos

Resolution: fixed
Status: acceptedclosed

comment:8 Changed 9 months ago by David.Byrne@…

I'm getting an error trying to run this with Trac 1.4.2. I'm getting:

File "/usr/lib/python2.7/site-packages/trac/web/main.py", line 639, in dispatch_request          
  dispatcher.dispatch(req)
File "/usr/lib/python2.7/site-packages/trac/web/main.py", line 271, in dispatch          
  method=method)
File "/usr/lib/python2.7/site-packages/trac/web/chrome.py", line 1443, in render_template          
  fragment, iterable, method)
File "/usr/lib/python2.7/site-packages/trac/web/chrome.py", line 1521, in _render_jinja_template          
  iterable)
File "/usr/lib/python2.7/site-packages/trac/web/chrome.py", line 1952, in _filter_jinja_page          
  stream |= self._filter_stream(req, method, filename, data)
File "/usr/lib64/python2.7/site-packages/genshi/core.py", line 133, in __or__          
  return Stream(_ensure(function(self)), serializer=self.serializer)
File "/usr/lib/python2.7/site-packages/trac/web/chrome.py", line 1912, in inner          
  stream, data)
File "/usr/lib/python2.7/site-packages/Roadmap_Plugin-0.4.2.dev0-py2.7.egg/roadmapplugin/roadmap.py", line 370, in filter_stream          
  html = HTML(html_str)
File "/usr/lib/python2.7/site-packages/trac/util/html.py", line 1252, in HTML          
  return Stream(list(parser))
File "/usr/lib64/python2.7/site-packages/genshi/core.py", line 274, in _ensure          
  event = stream.next()
File "/usr/lib64/python2.7/site-packages/genshi/input.py", line 449, in _coalesce          
  for kind, data, pos in chain(stream, [(None, None, None)]):
File "/usr/lib64/python2.7/site-packages/genshi/input.py", line 337, in _generate          
  raise UnicodeError("source returned bytes, but no encoding specified")

comment:9 Changed 9 months ago by Ryan J Ollos

Which version of Genshi do you have? This topic looks familiar. I tested with Genshi 0.7.5. I'll test with the version of Genshi you are using.

See also #12886.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.