Modify

Opened 9 months ago

Last modified 6 months ago

#14044 new defect

not work with Trac 1.4?

Reported by: mliszka@… Owned by: ttressieres
Priority: normal Component: DownloadsPlugin
Severity: normal Keywords:
Cc: Trac Release: 1.4

Description (last modified by Jun Omae)

Hi I have just installed fresh Trac 1.4.3. (we need to upgrade and move our actual Trac 0.12 to new OS :). So after installation plugin downloadsplugin-18442.zip it is not work with Trac 1.4.3. IS this plugin still alive? looks like not. After installation and adding default new tags like below:

[downloads]
additional_tags = author,component,version,architecture,platform,\
                  type # If TagsPlugin is installed
architecture_sort = name
architecture_sort_direction = asc
consoleadmin_user = anonymous
download_sort = time
download_sort_direction = desc
ext = zip,gz,bz2,rar
max_size = 268697600
path = ../downloads
platform_sort = name
platform_sort_direction = asc
type_sort = name
type_sort_direction = asc
unique_filename = False
visible_fields = id,file,description,size,time,count,author,tags,\
                 component,version,architecture,platform,type
[components]
tracdownloads.* = enabled

Trac not work. I can't made project upgrade:

[root@centos8-1 ~]#  trac-admin /opt/Trac/Firstproject/ upgrade
Error: Unable to check for upgrade of tracdownloads.init.DownloadsInit: TypeError: environment_needs_upgrade() takes exactly 2 arguments (1 given)

Any help?

Attachments (3)

t14044.diff (3.2 KB) - added by Jun Omae 9 months ago.
legacy_henshi_needed.PNG (50.4 KB) - added by mliszka@… 9 months ago.
admin_panel.PNG (3.4 KB) - added by mliszka@… 9 months ago.

Download all attachments as: .zip

Change History (16)

comment:1 Changed 9 months ago by Jun Omae

Description: modified (diff)

comment:2 Changed 9 months ago by Jun Omae

Trac Release: 1.4

comment:3 Changed 9 months ago by Jun Omae

The plugin is currently not compatible with Trac 1.4.x. Could you please try t14044.diff patch and let us know the results?

Changed 9 months ago by Jun Omae

Attachment: t14044.diff added

comment:4 Changed 9 months ago by mliszka@…

Can you send me quick instruction how to implement this change?

comment:5 Changed 9 months ago by Jun Omae

$ curl https://trac-hacks.org/raw-attachment/ticket/14044/t14044.diff -o /tmp/t14044.diff
$ svn export https://trac-hacks.org/svn/downloadsplugin/trunk /tmp/downloadsplugin
$ cd /tmp/downloadsplugin
$ patch -p0 </tmp/t14044.diff
$ python setup.py bdist_egg

Changed 9 months ago by mliszka@…

Attachment: legacy_henshi_needed.PNG added

comment:6 Changed 9 months ago by mliszka@…

Hi I found update command in google. After your patch implementation, trac-admin project_name upgrade commands finish with succes. I see new Donwloads button on project menu tab. But IDownloads page can't be present. I attached screen legacy_henshi_needed.PNG

Changed 9 months ago by mliszka@…

Attachment: admin_panel.PNG added

comment:7 Changed 9 months ago by mliszka@…

Hi also not working any links from admin panel "Download system" section. Only blank white page (no html any content).

comment:8 Changed 9 months ago by anonymous

what is actually the last Trac stable version with this plugin works?

comment:9 Changed 9 months ago by Ryan J Ollos

The project wiki page is tagged with Trac 1.2, so likely that version.

comment:10 Changed 9 months ago by ttressieres

Hi, I was on holidays, I will update the trunk tomorrow to update this plugin to work with Trac 1.4. Regards

comment:11 Changed 9 months ago by ttressieres

In 18443:

update DownloadsPlugin to support Trac 1.4.x (see #14044)

  • switch to jinja2 templates
  • support Trac 1.4 API

comment:12 Changed 6 months ago by anonymous

Hi Today I have to install newest Trac 1.4.3 on new fresh environement. I have just installed the newest plugin. downloadsplugin-18457.zip. I created new project. Add to trac.ini:

[components]
tracdownloads.* = enabled

[downloads]
additional_tags = author,component,version,architecture,platform,\
                  type # If TagsPlugin is installed
architecture_sort = name
architecture_sort_direction = asc
consoleadmin_user = anonymous
download_sort = time
download_sort_direction = desc
ext = zip,gz,bz2,rar
max_size = 268697600
path = /var/lib/trac/projects/secondproject
platform_sort = name
platform_sort_direction = asc
type_sort = name
type_sort_direction = asc
unique_filename = False
visible_fields = id,file,description,size,time,count,author,tags,\
                 component,version,architecture,platform,type

I did also command: trac-admin /var/lib/trac/projects/secondproject upgrade

no errors. I can add files from trac-admin command line. But I don't see downloads tab in project GUI.

Last edited 6 months ago by Jun Omae (previous) (diff)

comment:13 Changed 6 months ago by mliszka@…

Sorry my last post was as anonymous and without formatted text. It looks like patch for version 1.4 has missing something in GUI files.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain ttressieres.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.