Modify ↓

Opened 3 years ago

Closed 2 years ago

#14162 closed defect (fixed)

Don't use monkey patch to TracError.__str__

Reported by: Jun Omae Owned by: Dirk Stöcker
Priority: normal Component: CollapsiblePlugin
Severity: blocker Keywords:
Cc: Trac Release:

Description

I noticed the plugin uses monkey patch to TracError.__str__ at source:/collapsibleplugin/0.12/traccollapsible/__init__.py@:29​. Don't absolutely use it. 

# Ignore errors to avoid Internal Server Errors
from trac.core import TracError
TracError.__str__ = lambda self: unicode(self).encode('ascii', 'ignore')

Attachments (0)

Change History (2)

comment:1 Changed 2 years ago by Ryan J Ollos

Owner: changed from codingking to Dirk Stöcker
Status: new → assigned

comment:2 Changed 2 years ago by Dirk Stöcker

Resolution: → fixed
Status: assigned → closed

In 18568:

ready for Trac 1.6, fix #12187, fix #14155, fix #14162, fix #13957

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Dirk Stöcker.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.