Modify ↓
Opened 21 months ago
Last modified 21 months ago
#14214 new defect
Static analysis updates
Reported by: | figaro | Owned by: | Jun Omae |
---|---|---|---|
Priority: | low | Component: | TicketCalendarPlugin |
Severity: | normal | Keywords: | patch |
Cc: | Trac Release: |
Description
Attached an update based on static analysis:
- Added locales: de, fr, nl, sv
- Added a few docstrings to appease pylint
- In web_ui.py, line 317: W4902: Using
deprecated
method getargspec() (deprecated-method):replace with?:if 'db' in inspect.getargspec(Query.execute)[0]:
if 'db' in inspect.getfullargspec(Query.execute)[0]:
Attachments (3)
Change History (7)
Changed 21 months ago by
Attachment: | ticketcalendarplugin.diff added |
---|
Changed 21 months ago by
Attachment: | locale.tar.gz added |
---|
Locales fr, de, nl and sv for ticketcalendarplugin
comment:1 Changed 21 months ago by
- In web_ui.py, line 317: W4902: Using
deprecated
method getargspec() (deprecated-method):
Thanks. However, the plugin is not support Python 3 yet. See What’s New In Python 3.5 — Python 3.11.2 documentation.
comment:2 Changed 21 months ago by
I don't think it is necessary to check styling of code in the literals.
- cursor.execute('SELECT name FROM enum WHERE type=%s' + cursor.execute('SELECT name FROM enum WHERE type = %s'
In my code style, doesn't put spaces around =
in named parameters.
item = tag.li(title='#%d %s' % (t.get('id'), t.get('summary')), - style=style, - data_href=req.href('ticketcalendar-ticket', id=tktid)) + style = style, + data_href = req.href('ticketcalendar-ticket', id = tktid))
Changed 21 months ago by
Attachment: | ticketcalendarplugin.2.diff added |
---|
Diff -ur of ticketcalendarplugin
Note: See
TracTickets for help on using
tickets.
Diff -u of traccalendarplugin