[patch] Pass old_password when changing password

[g2p]

This patch changes the prototype of set_password to take an additional parameter, old_password. This is necessary for changing passwords on an LDAP server (the patch at #1600 ). The new parameter has a default value of None, so that the API remains compatible.

[g2p]

Patch against ​http://trac-hacks.org/svn/accountmanagerplugin/trunk

[g2p]

Patch against ​http://trac-hacks.org/svn/accountmanagerplugin/0.10

[Larry Ruiz]

Hi, this is an important patch for those using LDAP, could someone apply this patch to the code baseline?

[Steffen Hoffmann]

Replying to lruiz:

Hi, this is an important patch for those using LDAP, could someone apply this patch to the code baseline?

Hello, I've just taken over maintainership and going through the massive pile of tickets here. Saying sorry for all the time, this and many other patches have been sleeping here doesn't help. I'll be up to apply patches, as my time permits and following priority.

A short reply would help me to decide, if this one here is still relevant for 0.10 branch, trunk or both, and of course your vote would influence handling of #1602 as well.

[Larry Ruiz]

It is still valid.

[Steffen Hoffmann]

Replying to lruiz:

It is still valid.

Thanks for the confirmation. So this will be another addition to my patch stack.

[Steffen Hoffmann]

(In [9275]) AccountManagerPlugin: Add optional attribute old_password to set_password method, closes #1602.

This is a backwards-compatible API change. It's meant to prepare for adding AuthStores, that need to know both, old and new password for password change, like the proposed LdapAuthStore, refs #1600. Unittests are added to cover the method extension as well.