Cannot add a comment to a line

[c.posluschni@…]

If I try to add a comment on a line (open dialog, type in a few words and click Add comment) Loading... appears (see pic 1). A refresh leads to No Comments on line (see pic 2). After a click on Add Comment(pic 2) the following error occurs:

Traceback (most recent call last):
  File "/usr/local/lib/python2.4/site-packages/trac/web/main.py", line 387, in dispatch_request
    dispatcher.dispatch(req)
  File "/usr/local/lib/python2.4/site-packages/trac/web/main.py", line 237, in dispatch
    resp = chosen_handler.process_request(req)
  File "/usr/local/lib/python2.4/site-packages/TracCodeReview-2.0dev-py2.4.egg/codereview/peerReviewCommentCallback.py", line 44, in process_request
    self.createComment(req)
  File "/usr/local/lib/python2.4/site-packages/TracCodeReview-2.0dev-py2.4.egg/codereview/peerReviewCommentCallback.py", line 114, in createComment
    if hasattr(upload, 'filename') and upload.filename:
AttributeError: 'unicode' object has no attribute 'filename'

The file is already patched:
line 114, in createComment
if hasattr(upload, 'filename') and upload.filename:

Operating System: SLES 10
Trac 0.10.3.1

[c.posluschni@…]

pic 1: Loading...

[c.posluschni@…]

pic 2 : No comment

[c.posluschni@…]

Tested with Firefox 2.0.0.1 and IE 6.0

[anonymous]

Additional informations:

• Apache: 2.2.3
• mod_python: 3.1.3
• python: 2.4.2

[c.posluschni@…]

fixed with #1727

[sassyn@…]

can someone attach the patch. i still unable to fix this. i can't compile the file due to 'inconsistent use of tabs and spaces in

indentation'

i changed the tabs, spaces etc... but no luck

[c.posluschni@…]

#1727 did not fix the problem for me too.

Because #1727 did not work, I commented out the lines where the Attach-File-Checkbox is implemented in peerReviewCommentCallback.cs

Attention: You are not able to add attached files with this workaround.

[Joseph Lombrozo]

Sorry, should have mentioned, grab the latest source, that version should work just fine. Myself and sontek have taken over maintenance of this plugin. Things should be changing rapidly here, so keep an eye on the wiki page!