Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#204 closed defect (wontfix)

Incorrect syntas used when generating the account prefix for the htpasswd file.

Reported by: anonymous Owned by: Matt Good
Priority: high Component: AccountManagerPlugin
Severity: major Keywords:
Cc: Trac Release:


When using htpasswd as the authentication file, the prefix is incorrectly determined. Line 119 in is incorrect:

return user + ':'

should be

return '%s:' %(user)

which is similar to how the prefix for htdigest is determined.

Attachments (0)

Change History (1)

comment:1 Changed 11 years ago by Noah Kantrowitz

Resolution: wontfix
Status: newclosed

How exactly are these different. I could see an issue if it wasn't certain that user was a string, but I can see no way this would happen. If nothing else it would raise a TypeError, so it isn't a security bug. The current method is probably slighly more effcient (not that it much matters) as it avoids the string formatting call. If you have more of a reason this is incorrect, please append this ticket.

Modify Ticket

as closed The owner will remain Matt Good.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.