Opened 16 years ago

Last modified 10 years ago

#2188 new defect

Quotation handling on lastrow is broken

Reported by: jtiai Owned by: Jun Omae
Priority: normal Component: TracWysiwygPlugin
Severity: normal Keywords:
Cc: Daniel Kahn Gillmor Trac Release: 0.10


When pressing "reply" it's hard to write actual reply, since usually can't go beyond quoted text and quotation marks stays on.

Workaround is to go back to text mode, write foobar text and then switch back to wysiwyg mode.

When replying editing should start on a new line / paragraph after quotation.

Attachments (0)

Change History (5)

comment:1 Changed 16 years ago by jtiai

Summary: Replying ticket is problematic in WYSIWYG modeQuotation handling on lastrow is broken

Actually this is consistent: if there is quotation at the end of text

This is bar

> And this is foo

After "this is foo" text you can't get rid of quotation markers when in wysiwyg mode.

Also behvior of "del(ete)" key is inconsistent. If you're on empty line where you switch to quote and pres "del" it removes quotation instead of picking up next line.

comment:2 Changed 14 years ago by ruslan.shv

is there any issues?

comment:3 in reply to:  2 ; Changed 14 years ago by anonymous

Replying to ruslan.shv:

is there any issues?

try something like this

Index: tracwysiwyg/htdocs/wysiwyg.js
--- tracwysiwyg/htdocs/wysiwyg.js   (revision 8006)
+++ tracwysiwyg/htdocs/wysiwyg.js   (working copy)

@@ -1498,6 +1499,7 @@
     function closeQuote() {
         var target = getSelfOrAncestor(holder, "blockquote");
         holder = target.parentNode;
+        holder.appendChild(contentDocument.createElement("br"));

comment:4 in reply to:  3 Changed 14 years ago by Jun Omae

Replying to anonymous:

try something like this

Thanks for the patch, but it couldn't fix the issue and it has the problems in conversions of wikitext and DOM.

I checked the issue. Firefox has it, Google Chrome and Internet Explorer don't have it. Your browser is firefox?

comment:5 Changed 10 years ago by Daniel Kahn Gillmor

Cc: Daniel Kahn Gillmor added; anonymous removed

I can confirm the problem was present on firefox for me (see #2489)

Modify Ticket

Change Properties
Set your email in Preferences
as new The owner will remain Jun Omae.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.