Modify

Opened 15 years ago

Closed 20 months ago

Last modified 20 months ago

#224 closed enhancement (fixed)

Attach changeset to Code Review

Reported by: Tim DeFoggi Owned by: Cinc-th
Priority: normal Component: PeerReviewPlugin
Severity: normal Keywords:
Cc: alexhalf@…, kmacinni@…, jgeller@…, sam@…, Timothy Reaves, Marcus Lindblom, Ryan J Ollos Trac Release: 0.11

Description

It would be nice to have the ability to attach a changeset to a code review. This way it will automatically pull in all the files that were changed and the line numbers in to the code review.

Attachments (0)

Change History (31)

comment:1 Changed 15 years ago by anonymous

Trac Release: 0.8

I'd like to add my vote for this - it's impractical to enter each range of changed lines in each file. The changeset already has this information. Even better than a changeset might be to be able to select a range of revision numbers related to a folder - similar to the TortoiseSVN merge screen which allows you to merge between branches.

comment:2 Changed 14 years ago by anonymous

As an extension it'll be usefull to enter several files or even directory to make a full review (no need to enter the lines), for example for a review of a whole component

So at least a changeset will be A LOT usefull ! So I vote for this enhancement

comment:3 Changed 14 years ago by sontek

Owner: changed from Team5 to sontek
Priority: normalhigh
Severity: normalmajor
Trac Release: 0.80.10

This is a great idea

comment:4 Changed 13 years ago by anonymous

Cc: alexhalf@… added; anonymous removed

comment:5 Changed 13 years ago by iain@…

Has anyone made any progress on this ticket? Is anyone planning to? I've seen this mentioned as a blocker to people using this plugin in a few places (e.g. here); it is certainly the main problem I would have with using it.

From a quick look at the code, the work required to get a useable solution shouldn't be very hard. Here's what I propose. We simply add a "create review from changeset" option to the "create new code review" page, which has two user inputs: a text box for the revision number, and a "add files from this changeset" button. When the user presses the button, the data for that changeset is retrieved and entered in the page. In peerreviewplugin/branches/2.2-dev/codereview/peerReviewNew.py, it looks like the data would be added as is done around lines 89 and 144, and changeset data could be retrieved using methods from here

repos.get_changesets(old,new)

With line numbers worked out as _content_changes here.

Indeed, line numbers would be optional, and a first step would be just to retrieve the file names. This would give minimal working functionality, and quickly. There are a few things I don't know until I try it:

  • What to do if (and whether to allow) the user adds data from multiple changesets? Should the diffs merge?
  • How/whether to link a review back to the changeset it was reviewing.
  • How well it would work with non-svn repositories

I only installed the PeerReviewPlugin earlier today so I'm no expert, and I'm not sure if this is a reasonable design. Any thoughts?

comment:6 Changed 13 years ago by valent@…

I'm very interested in this feature aswell. Is it possible to resolve attaching changeset to code review in any way ?

comment:7 Changed 13 years ago by anonymous

Cc: kmacinni@… added

comment:8 Changed 13 years ago by anonymous

Cc: jgeller@… added

comment:9 Changed 12 years ago by sam@…

Cc: sam@… added

I just came across this module and I was hoping that it would have this particular feature.

sontek, if you don't have time to implement it yourself perhaps you could give some guidance as to where in the code someone would start trying to make a patch?

comment:10 Changed 12 years ago by Timothy Reaves

Trac Release: 0.100.11

Wow. Three years, and no action.

comment:11 Changed 12 years ago by Timothy Reaves

Cc: Timothy Reaves added

comment:12 Changed 12 years ago by anonymous

any progress?

comment:13 Changed 12 years ago by anonymous

Priority: highhighest
Severity: majorcritical

this would be definitely a big plus to attach one or more changesets. or do it the other way round: while browsing change sets it is possible to create code reviews, or annotate these changesets.

comment:14 Changed 12 years ago by anonymous

see #1553, which i marked as duplicate:

To really work with the review requests, it would make much sense to add the functionality of adding such requests to the changelog and diff view and the source browser. These are the places where usually a review request appears: during looking the new changes someone made. So it would be best if from there on one could add them

comment:15 Changed 12 years ago by Mike Stoddart

How about creating a review for a given ticket, and the plugin automatically retrieves all of the changesets commited against the ticket and uses that info for the review.

comment:16 Changed 12 years ago by Marcus Lindblom

Cc: Marcus Lindblom added

I just found this and was hoping for that too. (Automatic link with changeset, possibly ticket related.)

One could also imagine a workflow where each new changesets gets added in a review queue, then one creates a review based on one or more changesets.

comment:17 Changed 12 years ago by Ryan J Ollos

Cc: Ryan J Ollos added

comment:18 in reply to:  14 Changed 12 years ago by anonymous

Replying to anonymous:

see #1553, which i marked as duplicate:

To really work with the review requests, it would make much sense to add the functionality of adding such requests to the changelog and diff view and the source browser. These are the places where usually a review request appears: during looking the new changes someone made. So it would be best if from there on one could add them

Really most useful feature for me too. Current plugin functionality is useless for most developers as review changset is the most standard task for review. I also agree with functionality to create a CodeReview task from source browser or based on a ticket(all ticket`s changeset).

comment:19 Changed 11 years ago by Ryan J Ollos

There is a new plugin that looks like it may address this issue. Take a look at CodeReviewPlugin.

comment:20 Changed 10 years ago by Marc

Owner: changed from sontek to Marc

comment:21 Changed 8 years ago by Olemis Lang

Owner: changed from Marc to Olemis Lang

comment:22 Changed 7 years ago by anonymous

I guess this plugin is now dead? Was hoping to use it. :-(

Would have been quite nice!

comment:23 Changed 5 years ago by Cinc-th

Priority: highestnormal
Severity: criticalnormal

comment:24 Changed 4 years ago by Ryan J Ollos

Owner: Olemis Lang deleted

comment:25 Changed 20 months ago by Cinc-th

Owner: set to Cinc-th
Status: newaccepted

comment:26 Changed 20 months ago by Cinc-th

In 17458:

PeerReviewPlugin: create a review from a changeset. Note that complete files are added to the review (not segments).

Refs #224

Last edited 20 months ago by Ryan J Ollos (previous) (diff)

comment:27 Changed 20 months ago by Cinc-th

In 17459:

PeerReviewPlugin: added permission handling for review from changeset creation/viewing.

Refs #224

Last edited 20 months ago by Ryan J Ollos (previous) (diff)

comment:28 Changed 20 months ago by Cinc-th

In 17460:

PeerReviewPlugin: show information about changeset (if any) on view and perform pages.

Refs #224

Last edited 20 months ago by Ryan J Ollos (previous) (diff)

comment:29 Changed 20 months ago by Cinc-th

In 17461:

PeerReviewPlugin: allow review of changeset files with proper diff view. Some refactoring and code clean ups.

Refs #224

Last edited 20 months ago by Cinc-th (previous) (diff)

comment:30 Changed 20 months ago by Cinc-th

In 17462:

PeerReviewPlugin: fix for exception when a file was added in a changeset. Better context navigation during review by offering Next File and Previous File navigation items. Added links to repository, files, revisions etc. on perform review page. Added hints for links.

Refs #224

Last edited 20 months ago by Cinc-th (previous) (diff)

comment:31 Changed 20 months ago by Cinc-th

Resolution: fixed
Status: acceptedclosed

It is now possible to create a review directly from a changeset page. The files referenced in the changeset are automatically pulled into the created review.

During the code review one may comment using a diff view as usual. Maybe in the future commenting on the changeset page will be implemented. If so that and other enhancement will be tracked in separate tickets.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Cinc-th.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.