Modify

Opened 10 years ago

Last modified 3 years ago

#2324 new defect

[Patch] Reposearch always reindexes repository

Reported by: Jirka Vejrazka Owned by: anonymous
Priority: normal Component: RepoSearchPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.10

Description

Hello,

I found out that reposearch plugin always reindexes the repository upon search query. A bit of digging in the source code revealed that function need_reindex() in indexer.py compares self.repo.youngest_rev (type Unicode) with int(self.meta.get('last-repo-rev', -1)). These never match, therefore reindexing is started.

Changing int(self.meta.get('last-repo-rev', -1)) to unicode(self.meta.get('last-repo-rev', -1)) seems to solve the problem.

I'm using Trac 0.10.3 on Debian, if that's of any relevance. Latest revision of RepoSearch Plugin (reposearchplugin-r2920.zip)

Thanks for the great plugin BTW!

Jirka Vejrazka

Attachments (0)

Change History (7)

comment:1 Changed 10 years ago by Alec Thomas

Ah yes, I think this must have broken during one of the versioncontrol changes to support VCS's with non-numeric changeset identifiers.

Thanks for the fix, I'll commit soon.

comment:2 Changed 9 years ago by anonymous

Any progress on this? It seems like the latest release still has this issue.

comment:3 Changed 8 years ago by Geoff Jacobs

Thanks for the fix Jirka. I made the change on a local working copy, recompiled and it's working much better.

comment:4 Changed 7 years ago by Ryan J Ollos

Owner: changed from Alec Thomas to Ryan J Ollos

Reassigning ticket after changing maintainer of plugin.

comment:5 Changed 7 years ago by Ryan J Ollos

Summary: Reposearch always reindexes repository[Patch] Reposearch always reindexes repository

See also #3634. I will look at applying this fix.

comment:6 Changed 6 years ago by Ryan J Ollos

Hello,

I took over maintainership of this plugin from athomas some time ago. There is a significant amount of work to do on this plugin, and I don't foresee having the time to do it all.

helend has written the TracSuposePlugin, which seems like a much better solution. Rather than writing the repository search functionality from scratch, a Trac interface to an existing repository search tool has been created. Rather than throwing more effort at this plugin, I'd prefer to help helend with enhancements to the TracSuposePlugin, or spend my time on other Trac plugin projects altogether.

I'd like to get some feedback and hear if anyone knows of a compelling reason to continue this project rather than moving to the TracSuposePlugin. Is there functionality in this plugin that doesn't exist in the TracSuposePlugin? I'm open to hearing all opinions and suggestions.

I'll leave these tickets open for about a week, but in all likelihood will close all of them and deprecate the plugin.

Thanks for your time,

  • Ryan

comment:7 Changed 3 years ago by Ryan J Ollos

Owner: changed from Ryan J Ollos to anonymous

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.