Modify

Opened 9 years ago

Closed 9 years ago

#2882 closed defect (fixed)

trac-link source: broken

Reported by: anonymous Owned by: Sebastian Marek
Priority: normal Component: PeerReviewPlugin
Severity: normal Keywords: trac-links
Cc: Trac Release: 0.10

Description (last modified by Sebastian Marek)

When the Peerreview Plugin is installed are trac-links to sourcefiles are broken.

In the Wiki-text: [source:<repository-element> alternative text]

Before installing PeerReviewPlugin:
http://<trac-server>:<trac-port>/<project-name>/browser/<repository-element>

After installing PeerReviewPlugin:
http://<trac-server>:<trac-port>/<project-name>/peerReviewBrowser/<repository-element>

Versions used:

python 2.5.1
trac 0.10.4
svn 1.4.3
PeerReviewPlugin TracCodeReview-2.0dev

Note:
Disabling the sub-component peerReviewBrowser (while keeping all other sub-components enabled) switches back to the expected behavior.

Attachments (1)

mylyn-context.zip (843 bytes) - added by Sebastian Marek 9 years ago.
mylyn/context/zip

Download all attachments as: .zip

Change History (5)

comment:1 Changed 9 years ago by anonymous

Priority: highnormal
Severity: majornormal

Looking a little more into it i've found that peerReviewBrowser.py is an extender of IWikiSyntaxProvider. It wants to reformat links for 'browser', 'repos' and 'source'.

As i don't know what the intention of this is, i've commented out the 'source' part.

  • peerReviewBrowser.py

    old new  
    242242 
    243243    def get_link_resolvers(self):
    244244        return [('repos', self._format_link),
    245                 ('source', self._format_link),
     245        #        ('source', self._format_link),
    246246                ('browser', self._format_link)]
    247247 
    248248    def _format_link(self, formatter, ns, path, label):

Now trac-links starting with source: behave as expected. The browser: and repos: links still point to this plugin.

For what the repos: and browser: links are is unclear to me.

I hope that this is a fix or at least a workaround without to many unwanted side effects.

comment:2 Changed 9 years ago by Sebastian Marek

Description: modified (diff)
Status: newassigned

comment:3 Changed 9 years ago by Sebastian Marek

It actually break the wiki completly in trac 0.11. I think peerReviewBrowser shouldn't implement IWikiSyntaxProvider at all. Removing.

comment:4 Changed 9 years ago by Sebastian Marek

Resolution: fixed
Status: assignedclosed

Will merge those changes to 0.11 and trunk as well.

Changed 9 years ago by Sebastian Marek

Attachment: mylyn-context.zip added

mylyn/context/zip

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Sebastian Marek.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.