trac-link source: broken

[anonymous]

When the Peerreview Plugin is installed are trac-links to sourcefiles are broken.

In the Wiki-text: [source:<repository-element> alternative text]

Before installing PeerReviewPlugin:
http://<trac-server>:<trac-port>/<project-name>/browser/<repository-element>

After installing PeerReviewPlugin:
http://<trac-server>:<trac-port>/<project-name>/peerReviewBrowser/<repository-element>

Versions used:

python	2.5.1
trac	0.10.4
svn	1.4.3
PeerReviewPlugin	TracCodeReview-2.0dev

Note:
Disabling the sub-component peerReviewBrowser (while keeping all other sub-components enabled) switches back to the expected behavior.

[anonymous]

Looking a little more into it i've found that peerReviewBrowser.py is an extender of IWikiSyntaxProvider. It wants to reformat links for 'browser', 'repos' and 'source'.

As i don't know what the intention of this is, i've commented out the 'source' part.

peerReviewBrowser.py

@@ -242 +242 @@
  
     def get_link_resolvers(self):
         return [('repos', self._format_link),
-                ('source', self._format_link),
+        #        ('source', self._format_link),
                 ('browser', self._format_link)]
  
     def _format_link(self, formatter, ns, path, label):

Now trac-links starting with source: behave as expected. The browser: and repos: links still point to this plugin.

For what the repos: and browser: links are is unclear to me.

I hope that this is a fix or at least a workaround without to many unwanted side effects.

[Sebastian Marek]

It actually break the wiki completly in trac 0.11. I think peerReviewBrowser shouldn't implement IWikiSyntaxProvider at all. Removing.

[Sebastian Marek]

Will merge those changes to 0.11 and trunk as well.

[Sebastian Marek]

mylyn/context/zip