Bug when testing if environment needs upgrade

[anderson@…]

Hi,

I detected an bug when the plug-in tests if the environment needs upgrade. It counts how much items there are on the table votes. But, at least on MySQL, if there is no records, it don´t returns nothing. So commented the line above and everything worked great. If don´t do it, the trac always says that the database needs an upgrade.

Just one line commented on init.py:

def environment_needs_upgrade(self, db):

cursor = db.cursor() try:

cursor.execute("SELECT COUNT(*) FROM votes") #cursor.fetchone() return False

except:

return True

[anderson@…]

Please include this in next releases.

[daniele.domenichelli@…]

I confirm this bug on trac 0.11 with python 2.3 and MySQL 5.0.51a-community

[Dav Glass]

The actual problem is that MySQL is case sensitive. This code should make it work properly (attaching a patch file too):

    cursor.execute("select count(*) from votes")
    cursor.fetchone() return False

[Dav Glass]

Patch file for environment upgrade

[Jeff Hammel]

(In [6409]) fixes #3808; fixes #3298

[Steffen Hoffmann]

For what its worth the original way of testing for db table existence was insane, causing issues for PostgreSQL too. A real fix has been applied now with [12773].