Leaking LDAP connections

[memfis]

LdapPlugin doesn't seem to close the LDAP connections it makes. With every hit to a Trac page the system connection count grows. I haven't seen a single call to close() in LdapPlugin's source, why is that?

[Emmanuel Blot]

LDAP connections objects are dereferenced, which should close the connection when the object is garbage-collected.

The code needs some serious clean up though.

BTW, please be fair with priority and severity levels. You won't get better answers if you set levels unrelated to the actual issue.

[memfis]

Well, reality shows that they aren't. As far as I checked, the python ldap library doesn't have any destructors defined for any of its objects, so I don't see have the connection is supposed to be closed when they get dereferenced.

Now with the priority and severity levels. I don't know about you, but a problem that causes severe connection leaks and therefore makes a piece of software useless is a blocker to me.