Modify ↓

Opened 16 years ago

Closed 13 years ago

#3547 closed defect (fixed)

[Patch] Resubmit for review does not work

Reported by: haardt@… Owned by: mikechml
Priority: high Component: PeerReviewPlugin
Severity: critical Keywords:
Cc: Trac Release: 0.10

Description

Resubmitting a review throws an exception, for an simple fix see below.

Source: ​http://trac-hacks.org/svn/peerreviewplugin/0.10

Revision: 4137

  • codereview/peerReviewNew.py

     
    8787            popFiles = []
    8888            # Set up the file information
    8989            for struct in files:
    90                 returnFiles+=struct.Path + "," + struct.Version + "," + struct.LineStart + "," + struct.LineEnd + "#"
     90                returnFiles+=struct.Path + "," + str(struct.Version) + "," + str(struct.LineStart) + "," + str(struct.LineEnd) + "#"
    9191                tempFiles = []
    9292                tempFiles.append(struct.Path)
    9393                tempFiles.append(struct.Version)

Attachments (0)

Change History (1)

comment:1 Changed 13 years ago by Ryan J Ollos

Resolution: → fixed
Status: new → closed
Summary: Resubmit for review does not work). FIX included → [Patch] Resubmit for review does not work

This has been fixed on the trunk.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain mikechml.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.