Modify

Opened 16 years ago

Closed 13 years ago

#3615 closed enhancement (fixed)

[Patch] Improvements for Xref action

Reported by: daniel Owned by: Eli Carter
Priority: normal Component: AdvancedTicketWorkflowPlugin
Severity: normal Keywords:
Cc: Daniel Atallah Trac Release: 0.11

Description (last modified by Eli Carter)

I've made some enhancements to the xref action including:

  1. Verification that the target ticket exists.
  2. Including the comment change on the local ticket with the original save (so it appears in the change email and doesn't corrupt the ticket cnums)
  3. Sending a change email for the target ticket.

Attachments (1)

adv_ticket_workflow_xref_fixes.patch (3.7 KB) - added by Daniel Atallah 16 years ago.

Download all attachments as: .zip

Change History (7)

Changed 16 years ago by Daniel Atallah

comment:1 Changed 16 years ago by Daniel Atallah

Cc: Daniel Atallah added; anonymous removed

comment:2 Changed 15 years ago by hju@…

I'm facing the same problems.

I think we will try the patch.

Hope this will be included in a future release.

comment:3 Changed 15 years ago by anonymous

chang the patch, by adding a second except clause.



            try:
                xticket = model.Ticket(self.env, ticketnum)
            except ResourceNotFound, e:
                #put in preview mode to prevent ticket being saved
                req.args['preview'] = True
                add_warning(req, "Unable to cross-reference Ticket #%s (%s)." % (ticketnum, e.message))
                return {}
            except ValueError, e:
                #put in preview mode to prevent ticket being saved
                req.args['preview'] = True
                add_warning(req, "Unable to cross-reference Ticket #%s (%s).>%s< is not a number." % (ticketnum, e.message, ticketnum))
                return {}

comment:4 Changed 14 years ago by Ryan J Ollos

Summary: Improvements for Xref action[Patch] Improvements for Xref action

comment:5 Changed 14 years ago by Eli Carter

Description: modified (diff)

(fixed formatting of description)

comment:6 Changed 13 years ago by Eli Carter

Resolution: fixed
Status: newclosed

While it breaks the intent of the customizable workflow interface, it does improve the behaviour. Modified version of the patch applied in [9958]. Thanks!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Eli Carter.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.