Opened 9 years ago

Closed 5 years ago

Last modified 5 years ago

#3695 closed defect (fixed)

Picture Upload in "Preferences - My Profile"

Reported by: mail@… Owned by: Catalin BALAN
Priority: normal Component: UserManagerPlugin
Severity: normal Keywords: template
Cc: ejucovy, Ryan J Ollos Trac Release: 0.11


When i select a picture in "Preferences - My Profile" an click on "Save changes", the picture will not be uploaded.

Attachments (0)

Change History (12)

comment:1 Changed 9 years ago by Catalin BALAN

Resolution: fixed
Status: newclosed

comment:2 Changed 9 years ago by anonymous

Resolution: fixed
Status: closedreopened

This still does not work. The outputted form still lacks the enctype="multipart/form-data" property which prevents files from being uploaded. This is with version 0.4 installed today using easy_install.

comment:3 Changed 9 years ago by Catalin BALAN

Can you please provide trac and genshi version please ?

comment:4 Changed 9 years ago by anonymous

Trac:  	        0.11
Python: 	2.5.2 (r252:60911, Oct 5 2008, 19:42:18) [GCC 4.3.2]
setuptools: 	0.6c9
SQLite: 	3.5.9
pysqlite: 	2.4.1
Genshi: 	0.5
mod_python: 	3.3.1
Pygments: 	0.10
Subversion: 	1.5.1 (r32289)
jQuery:	        1.2.3

this is on Ubuntu using the standard versions in packages

comment:5 Changed 9 years ago by tekknokrat

Seems this issue is still open with Trac-

Can't find any relevant error messages in DEBUG log. Seems like the file submit is ignored when saving.

comment:6 Changed 8 years ago by lkraav

this operation just worked for me:

System Information
Trac: 	        0.11.6
Python: 	2.4.3 (#1, Sep 3 2009, 15:37:37) [GCC 4.1.2 20080704 (Red Hat 4.1.2-46)]
setuptools: 	0.6c11
SQLite: 	3.3.6
pysqlite: 	1.1.7
Genshi: 	0.5.1
mod_wsgi: 	4.0 (WSGIProcessGroup WSGIApplicationGroup %{GLOBAL})
FullBlog: 	0.1.1-r7622
jQuery:	        1.2.6

comment:7 Changed 7 years ago by anonymous

hi have the same problem on 0.11.1

Maybe it's javascript issue can you help please?

comment:8 Changed 6 years ago by uray

patch to fix this issue:

Index: 0.11/tracusermanager/templates/prefs_um_profile.html
--- 0.11/tracusermanager/templates/prefs_um_profile.html	(revision 10578)
+++ 0.11/tracusermanager/templates/prefs_um_profile.html	(working copy)
@@ -4,10 +4,10 @@
 <html xmlns=""
+	<xi:include href="prefs.html" />
     <py:match path="form[@id='userprefs']">
 		<form py:attrs="select('@*')" enctype="multipart/form-data">${select("*|text()")}</form>
-	<xi:include href="prefs.html" />
    		<title>${_('My Profile')}</title>

comment:9 Changed 6 years ago by ejucovy

Cc: ejucovy added; anonymous removed

comment:10 Changed 6 years ago by ejucovy

uray's patch in comment:8 works for me. Using trac 0.13-dev (trunk) @11017 and usermanager plugin from svn trunk@11434. Thanks uray!

comment:11 Changed 5 years ago by Steffen Hoffmann

Resolution: fixed
Status: reopenedclosed

(In [12152]) UserManagerPlugin: Correct [4262] to get picture upload finally working, closes #3695.

This patch has been kindly provided by uray more than one year ago. Because I promised cbalan to assist a bit, this is the least I can do. Sorry for taking so much time.

comment:12 Changed 5 years ago by Steffen Hoffmann

Cc: Ryan J Ollos added
Keywords: template added

Because of ejucovy's test feedback I expect this to work even on Trac-1.0 now.

Btw, the changed template has ugly white spacing, both blanks and tabs mixed seemingly random. Would love to not touch that code much more. Please note, that the decision is almost settled to get unique UserManager functionality back into AccountManager core, ultimately depreciating the separate development. This will be the time to clean all that up.

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Catalin BALAN.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.