Plugin does not respect NeverNotifyUpdaterPlugin

[hju@…]

First thank you for this little plugin. I was looking for the same issue and was thinking about an enhancement of the AdvancedTicketWorkflowPlugin. This is the better way I think.

We are using email2trac and want to notify the reporter as you mentioned in your description.

There is a lttle problem with NeverNotifyUpdaterPlugin which is no longer operating after installation of this plugin!

Reason seems to be that NeverNotifyUpdaterPlugin uses the same procedure:

4 	def get_recipients(self, tktid):
...
48	        if not notify_updater:
49 	            filter_out = True
50 	#             if notify_reporter and (updater == self.reporter):
51 	#                 filter_out = False
52 	#             if notify_owner and (updater == self.owner):
53 	#                 filter_out = False
54 	            if filter_out:
55 	                torecipients = [r for r in torecipients if r and r != updater]
56 	                ccrecipients = [r for r in ccrecipients if r and r != updater]
57 	        elif updater:
58 	            torecipients.append(updater)

Looks like that the behaviour depends on order of loading the eggs.

Is there a way to fix this? Perhaps in respecting each other?

[CStrac]

Both the plugins override the same method "get_recipients". Therefore I dont think they can mutually co-exist. Any two plugins overriding a method may not mutually co-exist.

But the functionality of both the plugins can be included in a single plugin.

[hju@…]

Sorry for the little delay...

This is exactly what I did. I included the NeverNotifyUpdaterPlugin-Code into this plugin creating a new version 0.0.2

The feature is activated by the new option NeverNotifyUpdater=true in [Notification] section of trac.ini

api.py

@@ -10 +10 @@
         notify_updater = self.config.getbool('notification', 
                                              'always_notify_updater')
     for_reporting = self.config.getlist('notification','reporter_states')
+        for_updating = self.config.getbool('notification','NeverNotifyUpdater')
         ccrecipients = self.prev_cc
         torecipients = []
         cursor = self.db.cursor()
@@ -53 +54 @@
     for updater, in cursor:
         break
     
+    # Check for NeverNotifyUpdater==true (included from NeverNotifyUpdaterPlugin)
+        if (not notify_updater) and (for_updating):
+           filter_out = True
+           if filter_out:
+              torecipients = [r for r in torecipients if r and r != updater]
+              ccrecipients = [r for r in ccrecipients if r and r != updater]
+        elif updater:
+              torecipients.append(updater)
     
 
         return (torecipients, ccrecipients)