Opened 9 years ago

Closed 8 years ago

# Cannot cancel edit of estimated hours field

Reported by: Owned by: Jason Winnebeck Joachim Hoessler normal EstimationToolsPlugin normal 0.11

### Description

After installing plugin on an existing trac with no hour estimates, I see a bunch of values "--". This is not a big deal, but if I click on one of those it starts edit mode, but I can't cancel the edit mode. Instead, if I click off of the value, it saves the value "--" to the actual ticket. Perhaps the value could go to blank/null if it is not a number, and also maybe the ticket shouldn't be updated if the field isn't actually changed.

### comment:1 Changed 9 years ago by Joachim Hoessler

Status: new → assigned

You can cancel the edit mode by pressing escape. But anyhow, you're right, the value should only be saved if the value has been changed.

### comment:2 Changed 8 years ago by osimons

Resolution: → fixed assigned → closed

(In [8758]) EstimationToolsPlugin: Quite a big batch of fixes and tweaks...

Issues resolved:

• Value only saved if actually changed, and if input is a number. Closes #3914
• closed_states are ignored for HoursRemaining macro. Closes #4132
• Ampersands supported in titles, milestones and any query arguments (correcting escaping/quoting). Closes #6889

New features / tweaks:

• Better error messages if no estimation field is configured; macros are disabled and the reason logged as error
• Custom title for the burndown chart
• Set remaining hours to empty instead of '--'
• Implemented decimal support whenever needed (not showing if not used)
• Implemented support for generating charts server-side (a chart proxy), primarily to provide better support for SSL. Option is default disabled
• Inplace editor now also works in wiki and milestone views, typically using TicketQuery macro
• Simplified the edithours.html javascript code + cleaned the code, tabs->spaces
• Obfuscate usernames in case they are email addresses

Tested with 0.11.x and 0.12.x and seems to work fine. Bumped version to 0.4.5.

### Modify Ticket

Change Properties