BreadCrumbsNavPlugin produces invalid xhtml (strict)

[jholg]

Disclaimer: I'm a newbie on these issues.

That said, Trac seems to produce nice valid xhtml 1.0 strict. breadcrumbsplugin breaks this by introducing <lh>Breadcrumbs:<lh>, with <lh/> not being allowed as a child of <ul/>

Proposed fix: Change the relevant css portion to

ul#breadcrumbs li:first-child {

color: #d1d1d1;

}

and make the "Breadcrumbs:" string appear as a simple <li/> instead of an <lh/>, but with the different color. So the effect should be the very same. This seems to work for me with Firefox 2.0.0.6 and also IE 6. Patch diff attached.

Regards, Holger

[jholg]

breadcrumbsplugin patch for xhtml 1.0 validity

[jholg]

xhtml-validity patch for breadcrumbsnavplugin

[jholg]

pls ignore my last attachment, this is just a repost of the previous one - for some reason it does not get correctly rendered in trac, but it is not empty...

[Steffen Hoffmann]

Replying to jholg:

pls ignore my last attachment, this is just a repost of the previous one - for some reason it does not get correctly rendered in trac, but it is not empty...

Sure, don't worry. Diff renderer is known to have problems with some diff formats, i.e. on timestamps in the header. There is still the option to download in original format, that will reveal the full content.

[Steffen Hoffmann]

just straitening for changelog ;-)

[Steffen Hoffmann]

(In [10889]) BreadCrumbsNavPlugin: Make HTML markup valid XHTML, refs #3965.

Thanks to jholg for the report and contribution of better code. I took the chance to flatten the CSS code for readability.

[Steffen Hoffmann]

(In [10893]) BreadCrumbsNavPlugin: Assign Trac CSS classes for proper display, refs #3965.

The '|' after label, introduced by the fix for #3965, should be suppressed. While on it, add appropriate CSS class for the last list item too.

On the same move withdraw link style to allow for custom styling i.e. from site.css instead.

[Steffen Hoffmann]

(In [10896]) BreadCrumbsNavPlugin: Tag long overdue maintenance release 0.2, closes #2463, #3965, #4037, #4411, #7036 and #7231.

Fix erroneously introduced version mismatch between changelog and setup.py.

[Steffen Hoffmann]

(In [10901]) BreadCrumbsNavPlugin: Fix crumbs list handling, refs #3965.

Code introduced in [10893] was not handling an empty list gracefully. Futhermore, when hiding of current resource results in an empty list, the list label should be suppressed as well.