Modify

Opened 8 years ago

Closed 6 years ago

Last modified 6 years ago

#7231 closed enhancement (fixed)

[Patch] Make label "Breadcrumbs:" configurable

Reported by: anonymous Owned by: Steffen Hoffmann
Priority: normal Component: BreadCrumbsNavPlugin
Severity: normal Keywords: custom label
Cc: pipern Trac Release: 0.12

Description

Patch:

  • breadcrumbs.py

    a b  
    2323    supported_paths = ListOption('breadcrumbs', 'paths', '/wiki*,/ticket*,/milestone*',
    2424        doc='List of URL paths to allow breadcrumb tracking. Globs are supported.')
     25
     26    label = Option('breadcrumbs','label','Breadcrumbs:',
     27                   doc="""Text label to show before breadcrumb list""")
    2528   
    2629    compiled_ignore_pattern = None
     
    160163            )
    161164           
    162         insert = tag.ul(class_="nav", id="breadcrumbs")(tag.lh("Breadcrumbs:"), li)
     165        insert = tag.ul(class_="nav", id="breadcrumbs")(tag.lh(self.label), li)
    163166
    164167        return stream | Transformer('//div[@id="metanav"]/ul').after(insert)

Attachments (0)

Change History (10)

comment:1 Changed 8 years ago by pipern

Cc: pipern added; anonymous removed

comment:2 Changed 7 years ago by Pontus Enmark

comment:3 Changed 7 years ago by Ryan J Ollos

Summary: Make label "Breadcrumbs:" configurable[Patch] Make label "Breadcrumbs:" configurable

comment:4 in reply to:  2 Changed 7 years ago by Steffen Hoffmann

Keywords: custom label added; patch removed

Replying to penmark:

This issue is also addressed in http://trac-hacks.org/attachment/wiki/BreadCrumbsNavPlugin/breadcrumbs.diff

Sure, thanks for the pointer.

For the sake of completeness true i18n support providing localization according to configured languages in browser might still be preferred, making the label just an additional option, overwriting i18n label/per language once and for all users.

I'll put this on top of aforementioned patch soon.

comment:5 Changed 6 years ago by Steffen Hoffmann

Owner: changed from Stephen Hansen to Steffen Hoffmann
Status: newassigned

finally and visibly taking over responsibility after official maintainership change

comment:6 Changed 6 years ago by Steffen Hoffmann

(In [10892]) BreadCrumbsNavPlugin: Add configurable default list label, refs #7231 and #7790.

This modified version of the change suggested by anonymous reporter of #7231 and addressed in penmark's patch will work better with coming i18n support, with the drawback, that the implicit default value isn't visible within the configuration system. At least tried to address this by extending option doc.

comment:7 Changed 6 years ago by Steffen Hoffmann

Resolution: fixed
Status: assignedclosed

(In [10896]) BreadCrumbsNavPlugin: Tag long overdue maintenance release 0.2, closes #2463, #3965, #4037, #4411, #7036 and #7231.

Fix erroneously introduced version mismatch between changelog and setup.py.

comment:8 Changed 6 years ago by Ryan J Ollos

Should I delete the two attachments on the BreadCrumbsNavPlugin wiki page?

comment:9 Changed 6 years ago by Steffen Hoffmann

I've just copied these patch files with a reference on their original submission to #7790 and new ticket #9539 respectively.

So you can clean-up that wiki page now. Thanks for the suggestion.

comment:10 in reply to:  9 Changed 6 years ago by Ryan J Ollos

Replying to hasienda:

So you can clean-up that wiki page now. Thanks for the suggestion.

Cleaned-up.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Steffen Hoffmann.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.