Opened 16 years ago
Closed 16 years ago
#3970 closed defect (fixed)
FiveStarVotePlugin produces invalid xhtml strict
| Reported by: | jholg | Owned by: | Dav Glass |
|---|---|---|---|
| Priority: | normal | Component: | FiveStarVotePlugin |
| Severity: | major | Keywords: | xhtml, xhtml-strict |
| Cc: | Trac Release: | 0.11 |
Description
Like VotePlugin (for which I posted a fix), FiveStarVotePlugin currently introduces invalid XHTML 1.0 strict, which is what Trac normally produces:
From http://validator.w3.org:
Validation Output: 1 Error
- Error Line 63, Column 147: document type does not allow element "ul" here; missing one of "object", "ins", "del", "map", "button" start-tag.
…a total of 5"><ul class="star-rating"><li class="current-rating" style="width
The mentioned element is not allowed to appear in the context in which you've placed it; the other mentioned elements are the only ones that are both allowed there and can contain the element mentioned. This might mean that you need a containing element, or possibly that you've forgotten to close a previous element.
Solution: Embed the <ul/> part into <object/>. This works for me using Firefox 2 and IE 6. Note, though, that I'm by no means an expert on (x)html
Patch diff fix attached.
Nice plugin.
Regards, Holger
Attachments (1)
Change History (2)
Changed 16 years ago by
| Attachment: | fivestarvoteplugin_valid_xhtml.diff added |
|---|
comment:1 Changed 16 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
fivestarvoteplugin patch for xhtml 1.0 validity