Opened 10 years ago

Closed 10 years ago

#3970 closed defect (fixed)

FiveStarVotePlugin produces invalid xhtml strict

Reported by: jholg Owned by: Dav Glass
Priority: normal Component: FiveStarVotePlugin
Severity: major Keywords: xhtml, xhtml-strict
Cc: Trac Release: 0.11


Like VotePlugin (for which I posted a fix), FiveStarVotePlugin currently introduces invalid XHTML 1.0 strict, which is what Trac normally produces:


Validation Output: 1 Error

  1. Error Line 63, Column 147: document type does not allow element "ul" here; missing one of "object", "ins", "del", "map", "button" start-tag.

…a total of 5"><ul class="star-rating"><li class="current-rating" style="width

The mentioned element is not allowed to appear in the context in which you've placed it; the other mentioned elements are the only ones that are both allowed there and can contain the element mentioned. This might mean that you need a containing element, or possibly that you've forgotten to close a previous element.

Solution: Embed the <ul/> part into <object/>. This works for me using Firefox 2 and IE 6. Note, though, that I'm by no means an expert on (x)html

Patch diff fix attached.

Nice plugin.

Regards, Holger

Attachments (1)

fivestarvoteplugin_valid_xhtml.diff (688 bytes) - added by jholg 10 years ago.
fivestarvoteplugin patch for xhtml 1.0 validity

Download all attachments as: .zip

Change History (2)

Changed 10 years ago by jholg

fivestarvoteplugin patch for xhtml 1.0 validity

comment:1 Changed 10 years ago by Dav Glass

Resolution: fixed
Status: newclosed

(In [4561]) fixes #3970 and #3972

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Dav Glass.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.