Modify

Opened 9 years ago

Closed 8 years ago

Last modified 2 years ago

#4002 closed enhancement (fixed)

[Patch] Never Notify Updater and Always Notify Component Owner flags

Reported by: sromanow@… Owned by: Robert Corsaro
Priority: normal Component: AnnouncerPlugin
Severity: normal Keywords:
Cc: nic4@…, Michael Ching Trac Release: 0.11

Description

Two things:

  • Please add functionality of Never Notify Updater. Similar issue as #3778.
  • Please add Always Update Component Owner flag so I can disable emails to this recipient class.

Attachments (1)

legacy-never-notify-updater.patch (3.8 KB) - added by Michael Ching 8 years ago.
Implementation of "nevernotifyupdater" for announcer legacy subscriber

Download all attachments as: .zip

Change History (23)

comment:1 Changed 9 years ago by Steve Romanow

Owner: changed from Robert Corsaro to Steve Romanow

comment:2 Changed 9 years ago by Steve Romanow

Status: newassigned

comment:3 Changed 9 years ago by Steve Romanow

I like the thoughts on this ticket.

always* sure does get squishy when pressed.

I am concerned about if someone sets always_notify_updater and never_notify_updater. Since I am proposing carrying both options, it will be possible to set both on.

comment:4 Changed 9 years ago by anonymous

Cc: nic4@… added; anonymous removed

comment:5 in reply to:  3 Changed 8 years ago by Ryan J Ollos

Replying to slestak:

I like the thoughts on this ticket.


I completely agree with that. From the testing I have done, it seems that the Never Notify updater plugin works with the Announcer plugin, but the never notify settings are over-ridden when Notify me of changes to tickets that I own and Notify me of changes to tickets that I reported are selected.

So, if Notify me of changes to tickets that I own and Notify me of changes to tickets that I reported are selected, and you are not the owner or the reporter, then you won't get an email notification for your own update. But if you are the owner or reporter, you will receive an email notifying you of your own update.

comment:6 Changed 8 years ago by Ryan J Ollos

Cc: ryano@… added

comment:7 Changed 8 years ago by Steve Romanow

Owner: changed from Steve Romanow to anonymous
Status: assignednew

Changed 8 years ago by Michael Ching

Implementation of "nevernotifyupdater" for announcer legacy subscriber

comment:8 Changed 8 years ago by Michael Ching

Cc: Michael Ching added

Attached file adds user-configurable option to prevent emails originating from a user's own updates if "never_notify_updater" is enabled in the [announcer] section of trac.ini.

comment:9 Changed 8 years ago by Ryan J Ollos

Summary: Never Notify Updater and Always Notify Component Owner flags[Patch] Never Notify Updater and Always Notify Component Owner flags

Would it be possible to have this incorporated into the trunk?

comment:10 Changed 8 years ago by Ryan J Ollos

Owner: changed from anonymous to Robert Corsaro

Assigning to maintainer in case this one was missed.

comment:11 Changed 8 years ago by Robert Corsaro

Status: newassigned

comment:12 Changed 8 years ago by Robert Corsaro

I've been thinking about this a lot. The trouble is that the rules can be complicated. One of my goals with the announcer plugin is to give the user more control over what notifications they receive. It is hard to make these complex rules accessible to the user, but here is where my mind is at now. The UI would look something like this and would be in the users preferences:

+ notify me of changes to tickets that I own.
+ notify me of changes to tickets that I created.
+ notify me of changes to tickets that I modify.
etc..

The options would be setup to some default that makes sense for the site and the users would be able to do three things:

  • disable/enable a rule
  • select always/never for a rule
  • change the order of the rules

The rules would be applied in order, so the ones lower in the list would always take precedence. The + would be some drag-n-drop thing. We could have something more simple for sans-javascript.

Does this make sense and seem like something people would want? Any better ideas?

comment:13 in reply to:  12 Changed 8 years ago by Ryan J Ollos

Replying to doki_pen:

Seems like that would work well, provided you have the following rule.

+ notify me of my own changes to tickets.

Would there be a way by which the administrator could specify a default set of rules?

comment:14 Changed 8 years ago by Ryan J Ollos

Cc: ryano@… removed

comment:15 Changed 8 years ago by Ryan J Ollos

One issue I have noticed with the current patch is that if I have "subscribed" to a ticket by adding myself to the CC list, the "Don't notify me of my own changes to tickets" is not respected.

comment:16 Changed 8 years ago by Robert Corsaro

Resolution: fixed
Status: assignedclosed

I tested on trunk and it works. If you add your username to the CC field, then things work as expected. There is no reverse lookup for email addresses, so you'll have to think of email addresses in CC fields as anonymous users with no settings (for now). Make a new ticket for reverse address lookup and I'll think about it some more, but it's unlikely to get done soon.

comment:17 Changed 2 years ago by Qudus

Sorry for resurrecting this old ticket. I have googled a lot about this topic. And there doesn't seem to be a suitable solution so far.

The never_notify_updater option on the Announcer doesn't work. We're using Trac 1.0.8. never_notify_updater on Announcer is enabled and always_notify_updater on Notification is disabled. I have even added a user setting to never notify myself about my own changes.

But I am still getting useless emails bout my own changes.

Is this really a bug? Am I doing or understanding something wrong? Why doesn't this work after all these years? What wins? notification or announcer? Why are there both of them? We haven't installed any plugins.

The option to never notify myself about my own changes should always win over any other setting. May it be a global option or a user setting or a global default to a user setting.

comment:18 in reply to:  17 Changed 2 years ago by Ryan J Ollos

Replying to Qudus:

We haven't installed any plugins.

Then you aren't using AnnouncerPlugin. If you are using Trac 1.0.x without any plugins, then you only need to be concerned with the notification section. You can try using NeverNotifyUpdaterPlugin to prevent notifications to self.

AnnouncerPlugin is being integrated to Trac for release 1.2, which should add the never notify self option (see trac:#2247)

comment:19 Changed 2 years ago by Qudus

Thanks for the reply.

I am a bit confused. We just installed the latest Trac 1.0.8. There's no sign of 1.2.x. And according to the changelog the never_notify_updater thing was added with 1.0.3, though not functioning obviously.

The announcer brings the "never_notify_updater" option with it. I don't see "never_notify_self". This is really confusing, since on the internet there are a lot of articles, that tell about _self or _updater. I think, the Trac project should feature an FAQ about this topic, since it interests so many people and doesn'T seem to be easily configured, if even working.

When I last visited the NeverNotifyUpdaterPlugin's project page just a few days ago it said, that it was deprecated and replaced by Trac 1.0.3 core features. I don't see anything about this message now. All this is sooo confusing. We tried this plugin a year back and it didn't work. I will try it again.

Can you answer a question please? Why is this topic so complicated? Isn't it a simple and comprehencible request to never receive notifications about my own actions? I understand, that it might be a user option, but not a server wide option, which has been discussed here and there. But why doesn't the Trac project want this option to be available through core features and transparently and easily configuired?

comment:20 Changed 2 years ago by Ryan J Ollos

Trac 1.0.x does not include never notify updater (self) functionality. For that you will need to use NeverNotifyUpdaterPlugin.

Trac 1.2 has not been released yet, but may include never notify updater (self) functionality, provided trac:#2247 is resolved by the time of the release.

Don't bother with AnnouncerPlugin. It's unmaintained and many features are broken.

comment:21 Changed 2 years ago by Qudus

Yes, I know that ticket. Should be simple to elaborate a solution and fix this bug. If you're honest, it really isn't such a big deal.

Thanks for your time.

comment:22 Changed 2 years ago by Ryan J Ollos

Feel free to provide a patch then.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Robert Corsaro.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.