Modify ↓
Opened 16 years ago
Closed 16 years ago
#4180 closed defect (fixed)
[Patch] Correction of some visual defects
Reported by: | Philippe Martens | Owned by: | Colin Guthrie |
---|---|---|---|
Priority: | normal | Component: | WorkLogPlugin |
Severity: | normal | Keywords: | patch |
Cc: | Trac Release: | 0.11 |
Description
I like very much this plugin, except for some visual bugs, so I choose to correct them.
With the plugin enabled, the active tab in mainnav isn't showed anymore
Normally, the active tab is shown in white over a black background (actually, an image with a black gradient). This is lost when the plugin is active.
Cause
The reference to the CSS stylesheet is added in an IRequestFilter
. This prematurely creates the chrome
attribute of the req
object, without the correct handler in context.
Resolution
- Moved
add_stylesheet
toprocess_request
inwebui.py
; - Added
add_stylesheet
inticket_filter.py
andtimeline_hook.py
; - Completely removed
IRequestFilter
implementation.
Link in admin opens the main Worklog tab
It should open the Work Log admin page.
- Pattern in
webui.py
changed to/^worklog/
, so it is recognized only when in first position.
Some components go beyond the Stop Work popup window boundaries
- Added CSS for
textarea
so its size depends on the popup size; - Works for FF3;
- For IE6-7, not really better, but not worse;
- Not tested with other browsers.
Attachments (1)
Change History (2)
Changed 16 years ago by
Attachment: | worklogplugin-0.11-r3890.patch added |
---|
comment:1 Changed 16 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
(In [5022]) Fix various issues relating to styling and clickability of links. Many thanks to phm for the patch. Fixes #4180 and Refs #3927