Opened 8 years ago

Last modified 6 weeks ago

#4247 new defect

Plugin doesn't seem to take into account Trac timezone settings

Reported by: SteveDH Owned by:
Priority: normal Component: WorkLogPlugin
Severity: normal Keywords:
Cc: Steffen Hoffmann Trac Release: 0.11


Not sure if anyone is still working on this but. I'm using Trac 0.11 The server that trac is running on is in the US however we are in the UK The Timing and Estimation Plugin correctly displayes its times in its reports The Times in the WorkLogPlugin all look as if they are using a us timezone

Attachments (0)

Change History (6)

comment:1 Changed 8 years ago by Colin Guthrie

Status: newassigned

Hmmm, interesting. I'm all UK here and don't have a problem but I'm guessing I've not taken some setting or other into account.

I'll have a looksee.

comment:2 Changed 6 years ago by Ryan J Ollos

It sounds like the default_timezone parameters in the [trac] section of trac.ini is being ignored, and that likely means that any user-specific settings in the Date & Time panel on the Preferences page are also being ignored.

This will be a problem for me since my server is located +2 hours from where I'm at. I'll take a look at this later today and see if a quick patch can be made.

comment:3 Changed 6 years ago by Colin Guthrie

Yeah I'm aware of my generally crappy handling of timezones in both this plugin and my ClientsPlugin too. I sometimes use int(time.time()) to calculate a timestamp rather than using API calls etc. which is a bad idea. Also in the 0.12 branch I don't extend my timestamp values to the new format (multiply by 10^6)... Anything you can do to fix this up would be greatly appreciated :)

comment:4 Changed 6 years ago by Ryan J Ollos

Potentially related to #2883. I'll test the behavior after creating a patch to address this ticket.

comment:5 Changed 6 years ago by Ryan J Ollos

Cc: Steffen Hoffmann added; anonymous removed

I've done a bunch of work this week with the trac.utils.datefmt API for the TracMetrixPlugin, so I should be able to get you a patch for the WorkLogPlugin this weekend.

I've also patched up the TracHoursPlugin a bit over the past week. It seems like, in the long term, merging the WorkLogPlugin with the TracHoursPlugin would be a nice thing to do, and it would take care of #4416 and potentially help with comment:3#2880. This could be done in such a way that features could be turned off and it could still work nicely with the TimingAndEstimationPlugin. What are your thoughts on that?

Also, I haven't spent a bunch of time looking at the TimingAndEstimationPlugin, but my initial thought is that the TimingAndEstimationPlugin is generally better for groups working with outside client (billing support and such), and TracHoursPlugin is generally better for internal company use where billing is not tracked. What do you think? Any other significant differences you know of?

comment:6 Changed 6 weeks ago by Ryan J Ollos

Owner: Colin Guthrie deleted
Status: assignednew

Modify Ticket

as new The ticket will remain with no owner.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.