Modify

Opened 9 years ago

Last modified 3 months ago

#4357 new enhancement

Enable CODE_REVIEW_DEV and CODE_REVIEW_MGR permmision by peerReviewInit

Reported by: okamototk Owned by:
Priority: normal Component: PeerReviewPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

Hi,

I wrote Trac Lightning which is Trac distribution with Subversion, Hudson, etc. It's purpose is not only for software developer. In software development peerreview plugin is very valuable but it's unnecessary for other perpose.

So, I would like to disable/enable peerreview menu by peerReviewMain plugin. However CODE_REVIEW_DEV and CODE_REVIEW_MGR permission are broken while peerReviewMain was disabled.

So, I would like to move IRequestorPermission interface in peerReviewMain to peerReviewInit. I attached the patch is included Trac Lightning.

I you took my patch, our codebase is same and I'm happy.

regards, -- Takashi Okamoto

Attachments (1)

move_permissionrequestor.patch (2.3 KB) - added by okamototk 9 years ago.
patch to enabled CODE_REVIEW_XX permission in peerReviewInit

Download all attachments as: .zip

Change History (3)

Changed 9 years ago by okamototk

patch to enabled CODE_REVIEW_XX permission in peerReviewInit

comment:1 Changed 6 years ago by Marc

Owner: changed from mikechml to Marc

comment:2 Changed 3 months ago by Ryan J Ollos

Owner: Marc deleted

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.