Opened 17 years ago
Closed 16 years ago
#4427 closed defect (duplicate)
wiki page not created if assigned a tag
| Reported by: | Owned by: | Alec Thomas | |
|---|---|---|---|
| Priority: | high | Component: | TagsPlugin |
| Severity: | critical | Keywords: | |
| Cc: | Trac Release: | 0.11 |
Description
Hi,
I just updated from Trac 0.10 to 0.11stable-r7778 and updaded TagsPlugin to the last version at the same time (r3117). Since, when creating a new wiki page and assigning a tag at the same time, the tag is created referencing the page but the wiki page is not created. When re-creating the page, the tag is remembered and everything goes fine. This happens wheter the tag already exists or not.
Cheers,
Michel
Attachments (0)
Change History (11)
comment:1 Changed 17 years ago by
comment:2 Changed 17 years ago by
| Severity: | major → critical |
|---|
Hi, i wanted to escallate the severity of this ticket. I am having the same issue, and have just lost an entire new wiki page because I listed a tag as I was creating a new page. None of the data fields are committed when the list of tags change.
comment:3 Changed 17 years ago by
| Priority: | normal → high |
|---|
comment:4 Changed 17 years ago by
Same problem here. Lost fresh content due to this. World is not ending, but it is annoying. I would like to invite colleagues to contribute content to our Trac based intranet, but this bug is holding me back. They would be very irritated and frustrated.
comment:5 follow-up: 6 Changed 17 years ago by
Seems the page.text attribute is not populated when validate_wiki_page is called. I patched it to check req.args.get('text') instead which fixed it for me. Patch against 0.6 below.
===================================================================
--- tags/0.6/tractags/wiki.py (revision 44154)
+++ tags/0.6/tractags/wiki.py (working copy)
@@ -52,7 +52,7 @@
if req and 'TAGS_MODIFY' in req.perm(page.resource) \
and req.path_info.startswith('/wiki') and 'save' in req.args:
if self._update_tags(req, page) and \
- page.text == page.old_text and \
+ req.args.get('text', '') == page.old_text and \
page.readonly == int('readonly' in req.args):
req.redirect(get_resource_url(self.env, page.resource, req.href, version=None))
return []
comment:6 Changed 17 years ago by
Replying to astroman:
Seems the page.text attribute is not populated when validate_wiki_page is called. I patched it to check req.args.get('text') instead which fixed it for me. Patch against 0.6 below.
Just to says:
This patch works for me too
Regards
comment:7 Changed 17 years ago by
Alec and other maintainers,
Any chance to see this patch integrated into the official distribution ?
Michel
comment:8 Changed 17 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
I believe this has been fixed in trunk for some time. If somebody can confirm that, I'll cut a new release soon.
comment:9 Changed 16 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
The patch posted above works but is not in trunk, yet.
comment:10 Changed 16 years ago by
This is pretty annoying if you miss this bug report and deploy 0.6... A new release would be nice.
comment:11 Changed 16 years ago by
| Resolution: | → duplicate |
|---|---|
| Status: | reopened → closed |
Duplicate of #3206.



The problem is even worst : this happens for every modification done in a wiki page (not only at creation) when modifying the tags attached to the page at the same time.
Michel