Modify

Opened 8 years ago

Closed 3 years ago

Last modified 3 years ago

#4548 closed defect (fixed)

[Patch] TypedTicketWorkflow should also override get_actions_by_operation_for_req

Reported by: Geoff Reedy Owned by: Ryan J Ollos
Priority: normal Component: TypedTicketWorkflowPlugin
Severity: normal Keywords:
Cc: Ryan J Ollos Trac Release: 0.11

Description

Other workflow plugins use ConfigurableTicketWorkflow.get_actions_by_operation_for_req to determine if their plugin's action can be used. Since TypedTicketWorkflow doesn't override this method it cannot be used to remove these actions from display. This patch implements this method.

Attachments (1)

typedticketworkflowplugin-4548.patch (763 bytes) - added by Geoff Reedy 8 years ago.
patch against r5169

Download all attachments as: .zip

Change History (13)

Changed 8 years ago by Geoff Reedy

patch against r5169

comment:2 Changed 8 years ago by Vladimir Abramov

Status: newassigned

Thanks for your patch. I'll apply it to next version

comment:3 Changed 7 years ago by Ryan J Ollos

Cc: Ryan J Ollos added; anonymous removed

comment:4 Changed 7 years ago by anonymous

Does this work? Been trying this and the "fix" on #4547 and cant get it to work properly...

Last edited 3 years ago by Ryan J Ollos (previous) (diff)

comment:5 in reply to:  4 Changed 7 years ago by anonymous

Replying to anonymous:

Does this work? Been trying this and the "fix" on #4547 and cant get it to work properly...

Ignore this comment.... I'm an idiot.... big difference between ticketype and ticketType.

Last edited 3 years ago by Ryan J Ollos (previous) (diff)

comment:6 in reply to:  2 Changed 7 years ago by anonymous

Replying to kivsiak:

Thanks for your patch. I'll apply it to next version

For when is the next version planned?

comment:7 Changed 7 years ago by Ryan J Ollos

Summary: TypedTicketWorkflow should also override get_actions_by_operation_for_req[Patch] TypedTicketWorkflow should also override get_actions_by_operation_for_req

comment:8 Changed 3 years ago by Geert

Hi, the patch works for me in Trac 1.0 using TypedTicketWorkflow_plugin-0.1dev_r4791-py2.7.egg.

Last edited 3 years ago by Ryan J Ollos (previous) (diff)

comment:9 Changed 3 years ago by Ryan J Ollos

Owner: changed from Vladimir Abramov to Ryan J Ollos
Status: assignedaccepted

Thanks, I'll apply the patch then.

comment:10 Changed 3 years ago by Ryan J Ollos

Resolution: fixed
Status: acceptedclosed

In 13574:

0.2dev: Override get_actions_by_operation_for_req . Fixes #4548.

Patch by geoff.

comment:11 Changed 3 years ago by Ryan J Ollos

Please report back if the latest version of typedticketworkflowplugin/trunk is working well for you, then I can remove the dev from version 0.2dev. Thanks!

comment:12 Changed 3 years ago by Geert

It works for me with Trac 1.0.

comment:13 Changed 3 years ago by Ryan J Ollos

In 13576:

0.2: Bump version from 0.2dev to 0.2. Refs #4548.

Thanks to glinders for testing the latest.

Modify Ticket

Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.