Modify

Opened 8 years ago

Closed 6 years ago

#4547 closed defect (fixed)

[Patch] AdvancedTicketWorkflow doesn't work with custom ConfigurableTicketWorkflow subclasses

Reported by: Geoff Reedy Owned by: Eli Carter
Priority: normal Component: AdvancedTicketWorkflowPlugin
Severity: normal Keywords:
Cc: hju@… Trac Release: 0.11

Description

Instances of ConfigurableTicketWorkflow are created directly in the plugin rather than searching TicketSystem.action_controllers for an appropriate instance. This can cause actions to be visible when they should not be, such as when TypedTicketWorkflowPlugin is being used. This patch searches for an instance of ConfigurableTicketWorkflow to use, creating a default one if necessary.

Attachments (1)

advancedticketworkflowplugin-4547.patch (2.0 KB) - added by Geoff Reedy 8 years ago.
patch against r5169

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by Geoff Reedy

patch against r5169

comment:1 Changed 8 years ago by anonymous

Cc: hju@… added; anonymous removed

comment:2 Changed 8 years ago by hju@…

The patch works fine.

But it is also necessary to replace

actions = ConfigurableTicketWorkflow(self.env).actions

with

actions = self.get_configurable_workflow().actions

comment:3 Changed 8 years ago by anonymous

Does anyone have more details on this?

I have tried to implement these changes a few times yet still cant get it to work.

comment:4 in reply to:  3 Changed 8 years ago by anonymous

Replying to anonymous:

Does anyone have more details on this?

I have tried to implement these changes a few times yet still cant get it to work.

Ignore this comment.... I'm an idiot.... big difference between ticketype and ticketType

comment:5 Changed 8 years ago by Ryan J Ollos

Owner: changed from Eli Carter to Ryan J Ollos
Status: newassigned
Summary: AdvancedTicketWorkflow doesn't work with custom ConfigurableTicketWorkflow subclasses[Patch] AdvancedTicketWorkflow doesn't work with custom ConfigurableTicketWorkflow subclasses

comment:6 Changed 8 years ago by Ryan J Ollos

Owner: changed from Ryan J Ollos to Eli Carter
Status: assignednew

comment:7 Changed 6 years ago by Eli Carter

Resolution: fixed
Status: newclosed

I reworked the patch somewhat and committed it in [9960]. Thanks!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Eli Carter.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.