Opened 16 years ago
Closed 14 years ago
#4547 closed defect (fixed)
[Patch] AdvancedTicketWorkflow doesn't work with custom ConfigurableTicketWorkflow subclasses
| Reported by: | Geoff Reedy | Owned by: | Eli Carter |
|---|---|---|---|
| Priority: | normal | Component: | AdvancedTicketWorkflowPlugin |
| Severity: | normal | Keywords: | |
| Cc: | hju@… | Trac Release: | 0.11 |
Description
Instances of ConfigurableTicketWorkflow are created directly in the plugin rather than searching TicketSystem.action_controllers for an appropriate instance. This can cause actions to be visible when they should not be, such as when TypedTicketWorkflowPlugin is being used. This patch searches for an instance of ConfigurableTicketWorkflow to use, creating a default one if necessary.
Attachments (1)
Change History (8)
Changed 16 years ago by
| Attachment: | advancedticketworkflowplugin-4547.patch added |
|---|
comment:1 Changed 16 years ago by
| Cc: | hju@… added; anonymous removed |
|---|
comment:2 Changed 15 years ago by
The patch works fine.
But it is also necessary to replace
actions = ConfigurableTicketWorkflow(self.env).actions
with
actions = self.get_configurable_workflow().actions
comment:3 follow-up: 4 Changed 15 years ago by
Does anyone have more details on this?
I have tried to implement these changes a few times yet still cant get it to work.
comment:4 Changed 15 years ago by
Replying to anonymous:
Does anyone have more details on this?
I have tried to implement these changes a few times yet still cant get it to work.
Ignore this comment.... I'm an idiot.... big difference between ticketype and ticketType
comment:5 Changed 15 years ago by
| Owner: | changed from Eli Carter to Ryan J Ollos |
|---|---|
| Status: | new → assigned |
| Summary: | AdvancedTicketWorkflow doesn't work with custom ConfigurableTicketWorkflow subclasses → [Patch] AdvancedTicketWorkflow doesn't work with custom ConfigurableTicketWorkflow subclasses |
comment:6 Changed 15 years ago by
| Owner: | changed from Ryan J Ollos to Eli Carter |
|---|---|
| Status: | assigned → new |
comment:7 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
I reworked the patch somewhat and committed it in [9960]. Thanks!
patch against r5169