WikiCssPlugin: PostgresSQL error with latest changeset

[Oliver Metz]

Hi.

With last update (​http://trac-hacks.org/changeset/5121) I get an error message in my log files:

2009-02-25 22:46:01,182 Trac[plugin] ERROR: FEHLER:  Spalte »wiki.version« muss in der GROUP-BY-Klausel erscheinen oder in einer Aggregatfunktion verwendet werden
2009-02-25 22:46:01,729 Trac[plugin] ERROR: FEHLER:  Spalte »wiki.version« muss in der GROUP-BY-Klausel erscheinen oder in einer Aggregatfunktion verwendet werden
2009-02-25 22:46:03,087 Trac[plugin] ERROR: FEHLER:  Spalte »wiki.version« muss in der GROUP-BY-Klausel erscheinen oder in einer Aggregatfunktion verwendet werden
2009-02-25 22:46:11,275 Trac[plugin] ERROR: FEHLER:  Spalte »wiki.version« muss in der GROUP-BY-Klausel erscheinen oder in einer Aggregatfunktion verwendet werden
2009-02-25 22:46:26,445 Trac[plugin] ERROR: FEHLER:  Spalte »wiki.version« muss in der GROUP-BY-Klausel erscheinen oder in einer Aggregatfunktion verwendet werden
2009-02-25 22:46:33,158 Trac[plugin] ERROR: FEHLER:  Spalte »wiki.version« muss in der GROUP-BY-Klausel erscheinen oder in einer Aggregatfunktion verwendet werden
2009-02-25 22:46:41,930 Trac[plugin] ERROR: FEHLER:  Spalte »wiki.version« muss in der GROUP-BY-Klausel erscheinen oder in einer Aggregatfunktion verwendet werden
2009-02-25 22:46:53,990 Trac[plugin] ERROR: FEHLER:  Spalte »wiki.version« muss in der GROUP-BY-Klausel erscheinen oder in einer Aggregatfunktion verwendet werden
2009-02-25 22:46:55,241 Trac[plugin] ERROR: FEHLER:  Spalte »wiki.version« muss in der GROUP-BY-Klausel erscheinen oder in einer Aggregatfunktion verwendet werden
2009-02-25 22:46:56,274 Trac[plugin] ERROR: FEHLER:  Spalte »wiki.version« muss in der GROUP-BY-Klausel erscheinen oder in einer Aggregatfunktion verwendet werden

Sorry for the german language but I know it's no problem for you. ;-)

I reverted the change and everything seems to works fine.

[Martin Scharrer]

Could you try the following short patch:

wikicssplugin/0.11/tracwikicss/plugin.py

@@ -46 +46 @@
             cursor.execute( \
                 "SELECT text, MAX(version) FROM wiki WHERE name='%s' " \
-                "GROUP BY text ORDER BY version DESC;" % self.wikipage )
+                "GROUP BY text,version ORDER BY version DESC;" % self.wikipage )
             content = cursor.fetchone()
             if not content:

[Martin Scharrer]

Sorry, the last line of the previous comment should be of course outside the text window. Here again the patch:

wikicssplugin/0.11/tracwikicss/plugin.py

@@ -46 +46 @@
             cursor.execute( \
                 "SELECT text, MAX(version) FROM wiki WHERE name='%s' " \
-                "GROUP BY text ORDER BY version DESC;" % self.wikipage )
+                "GROUP BY text,version ORDER BY version DESC;" % self.wikipage )
             content = cursor.fetchone()
             if not content:

[Oliver Metz]

With this change the error has gone but the plugin doesn't seem to work anymore or uses a wrong version of css page.

[Martin Scharrer]

I now simplified the SQL query ([5315]) to avoid the need for GROUP BY by kicking the unneeded MAX() out. Tell me if it works for you.

[Oliver Metz]

Because there is only one column in the result now I needed the following change:

tracwikicss/plugin.py

@@ -49 +49 @@
             content = cursor.fetchone()
             if not content:
                 raise Exception("WikiCss: Configured wiki page '%s' doesn't exits." % self.wikipage)
-            req.send(content[0], content_type='text/css', status=200)
+            req.send(content, content_type='text/css', status=200)
         except RequestDone:
             pass
         except Exception, e:

But now it works fine. Thank you.

[Martin Scharrer]

The fact when a scalar or a tuple is returned is still quite confusing for me. Python isn't my main programming language. I'm also not sure if this depends on the DB backend in this case. Therefore I put a simple test in ([5334]) to check if content is a tuple or not which is the most stable solution.

[Martin Scharrer]

This should be reprogrammed to use the WikiPage model provided by Trac.

[Martin Scharrer]

Fixed in [6951]. Now the WikiPage model of Trac is used which should make it completely compatible with all DB backends Trac itself supports.