Usage of deprecated md5 and sha (vs. hashlib)

[Justin R. Cutler]

The following warnings occur when using the AccountManagerPlugin under Python 2.6.

/usr/local/lib/python2.6/dist-packages/TracAccountManager-0.2.1dev_r5479-py2.6.egg/acct_mgr/pwhash.py:13: DeprecationWarning: the md5 module is deprecated; use hashlib instead
  import md5, sha
/usr/local/lib/python2.6/dist-packages/TracAccountManager-0.2.1dev_r5479-py2.6.egg/acct_mgr/md5crypt.py:14: DeprecationWarning: the md5 module is deprecated; use hashlib instead
  import md5

[jeberger@…]

Looks like there is an infinite recursion in the sha_new function when hashlib is unavailable: it calls itself instead of calling sha.new.

Moreover, arguments are not handled properly. It should be:

def sha_new (*args): 
    return sha.new (*args)

And something similar for md5_new.

[Justin R. Cutler]

Trivial patch to fix Python 2.6 warnings

[Justin R. Cutler]

The patch has been updated to fix both issues.

[Alex Knol]

I just applied the patch and now get a similar message on notification.py

/usr/local/lib/python2.6/dist-packages/TracWikiNotification-0.2.1-py2.6.egg/WikiNotification /notification.py:17: DeprecationWarning: the md5 module is deprecated; use hashlib instead

as before all works, just a warning.

[Justin R. Cutler]

Replying to alexknol@gmail.com:

I just applied the patch and now get a similar message on notification.py

/usr/local/lib/python2.6/dist-packages/TracWikiNotification-0.2.1-py2.6.egg/WikiNotification /notification.py:17: DeprecationWarning: the md5 module is deprecated; use hashlib instead

as before all works, just a warning.

I would recommend filing a ticket with the WikiNotificationPlugin (​http://wikinotification.ufsoft.org/), as your warning is the same issue, but for a different plugin.

[anonymous]

please consider applying this patch and get rid of the deprecation warnings. it's a good way to get ready for 3.0 thanks

[Matt Good]

(In [5836]) Use hashlib when available (fixes #4984)

[Matt Good]

(In [5837]) Use hashlib when available (fixes #4984)