Opened 9 years ago

Closed 2 years ago

#5434 closed defect (fixed)

Removing Files during Resubmit fails

Reported by: mlb5000 Owned by: Cinc-th
Priority: normal Component: PeerReviewPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description (last modified by Ryan J Ollos)

When Resubmitting a code review, if you click on a file in the list to remove it from the review, then Submit the code review, the files you removed remain. Steps for reproduction:

  1. Create a code review with one or more files.
  2. Open the review and click "Resubmit code review" at the bottom.
  3. Remove one or more files from the new code review.
    1. (optional) add one or more new files to the review.
  4. Click submit.

The files you removed in step 2 still remain. Any files added in 3a are added, however.

Attachments (0)

Change History (4)

comment:1 Changed 8 years ago by Ryan J Ollos

Description: modified (diff)

Confirmed with Trac 0.11.8dev-r9998.

comment:2 Changed 7 years ago by Marc

Owner: changed from Sebastian Marek to Marc

comment:3 Changed 2 years ago by Cinc-th

Owner: changed from Marc to Cinc-th
Status: newassigned
Summary: Removing Files during Resumit failsRemoving Files during Resubmit fails
Trac Release: 0.110.12

Problem shows with V0.12.3, too.

comment:4 Changed 2 years ago by Cinc-th

Resolution: fixed
Status: assignedclosed

In 15182:

  • Fixed regression in remove files function introduced with [15181]
  • Fixed problem with removing files when resubmitting.

Fixes #5434

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Cinc-th.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.