Opened 8 years ago

Closed 12 months ago

#5434 closed defect (fixed)

Removing Files during Resubmit fails

Reported by: mlb5000 Owned by: Cinc-th
Priority: normal Component: PeerReviewPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description (last modified by rjollos)

When Resubmitting a code review, if you click on a file in the list to remove it from the review, then Submit the code review, the files you removed remain. Steps for reproduction:

  1. Create a code review with one or more files.
  2. Open the review and click "Resubmit code review" at the bottom.
  3. Remove one or more files from the new code review.
    1. (optional) add one or more new files to the review.
  4. Click submit.

The files you removed in step 2 still remain. Any files added in 3a are added, however.

Attachments (0)

Change History (4)

comment:1 Changed 6 years ago by rjollos

  • Description modified (diff)

Confirmed with Trac 0.11.8dev-r9998.

comment:2 Changed 6 years ago by andersm

  • Owner changed from proofek to andersm

comment:3 Changed 12 months ago by Cinc-th

  • Owner changed from andersm to Cinc-th
  • Status changed from new to assigned
  • Summary changed from Removing Files during Resumit fails to Removing Files during Resubmit fails
  • Trac Release changed from 0.11 to 0.12

Problem shows with V0.12.3, too.

comment:4 Changed 12 months ago by Cinc-th

  • Resolution set to fixed
  • Status changed from assigned to closed

In 15182:

  • Fixed regression in remove files function introduced with [15181]
  • Fixed problem with removing files when resubmitting.

Fixes #5434

Add Comment

Modify Ticket

as closed The owner will remain Cinc-th.
The resolution will be deleted. Next status will be 'reopened'.

E-mail address and user name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.