[PATCH] KeyError: 'fields'

[jens.rantil@…]

How to Reproduce

While doing a GET operation on /ticket/2191, Trac issued an internal error.

I wanted to see the diff of a ticket summary change (url=/ticket/2191?action=diff&version=1).

Request parameters:

{'action': u'diff', 'version': u'1', 'id': u'2191'}

System Information

Trac	0.11.1
Python	2.4.4 (#1, Oct 22 2008, 20:17:05) [GCC 4.1.2 20061115 (prerelease) (Debian 4.1.1-21)]
setuptools	0.6c3
SQLite	3.3.8
pysqlite	2.3.2
Genshi	0.5.1
mod_python	3.2.10
Subversion	1.5.1 (r32289)

Python Traceback

Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 423, in _dispatch_request
    dispatcher.dispatch(req)
  File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 208, in dispatch
    template, data, content_type = \
  File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 299, in _post_process_request
    resp = f.post_process_request(req, *resp)
  File "build/bdist.linux-x86_64/egg/mastertickets/web_ui.py", line 64, in post_process_request
KeyError: 'fields'

[seltmann@…]

same here

[Frau Boonekamp]

The issue was that when you enter diff mode, the structure of the 'changes' datafield was different (and did not contain the 'fields' sub).

This patch bails out investigating the changes datastructure if we are in diff mode.

[Ivan]

+1 Have the same error with a ticket diff description. The patch fixed this. Thanks! I think the fix should be committed in to the svn.

[Frau Boonekamp]

Fixed in MasterTickets 3.0 (for Trac 0.12):

​http://github.com/coderanger/trac-mastertickets/commit/b46dc7e8614bf02a9c35ca14aa17962bc1ee3156

[Ryan J Ollos]

(In [12910]) Fix #5503, #6766 and #3920 with the patch from #3920: ​http://trac-hacks.org/attachment/ticket/3920/fix_ticket_diff.patch

[Patch] Error in code causing diff crash on tickets with changes in description only (web_ui.py)