Modify

Opened 8 years ago

Closed 5 years ago

#5517 closed defect (wontfix)

[Patch] Plugin does not work with git repositories

Reported by: martoss Owned by: Ryan J Ollos
Priority: normal Component: RepoSearchPlugin
Severity: normal Keywords:
Cc: ejucovy Trac Release: 0.11

Description (last modified by Ryan J Ollos)

when searching within a git repository:

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/trac/web/main.py", line 423, in _dispatch_request
    dispatcher.dispatch(req)
  File "/usr/lib/python2.5/site-packages/trac/web/main.py", line 197, in dispatch
    resp = chosen_handler.process_request(req)
  File "/usr/lib/python2.5/site-packages/trac/search/web_ui.py", line 106, in process_request
    results += list(source.get_search_results(req, terms, filters))
  File "build/bdist.linux-x86_64/egg/tracreposearch/search.py", line 80, in get_search_results
    self.indexer.reindex()
  File "build/bdist.linux-x86_64/egg/tracreposearch/indexer.py", line 97, in wrap
    return f(*args, **kw)
  File "build/bdist.linux-x86_64/egg/tracreposearch/indexer.py", line 236, in reindex
    if not self.need_reindex():
  File "build/bdist.linux-x86_64/egg/tracreposearch/indexer.py", line 97, in wrap
    return f(*args, **kw)
  File "build/bdist.linux-x86_64/egg/tracreposearch/indexer.py", line 168, in need_reindex
    int(self.meta.get('last-repo-rev', -1)) \
ValueError: invalid literal for int() with base 10: '798217062dcecac7d0af12bf995e4838b7e93e18'

Git does not use plain integers as revision numbers. I removed the int() in the line but indexing/searching within the source still doesn't work.

Attachments (2)

trac-reposearch-plugin-git.patch (638 bytes) - added by twpayne@… 8 years ago.
Patch for RepoSearchPlugin to work with git repositories
trac-reposearch-plugin-git.2.patch (1.1 KB) - added by twpayne@… 8 years ago.
Patch for RepoSearchPlugin to work with git repositories

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by twpayne@…

Patch for RepoSearchPlugin to work with git repositories

Changed 8 years ago by twpayne@…

Patch for RepoSearchPlugin to work with git repositories

comment:1 Changed 8 years ago by Ryan J Ollos

Summary: plugin does not work with git repositories[Patch] Plugin does not work with git repositories

comment:2 Changed 8 years ago by Ryan J Ollos

Owner: changed from Alec Thomas to Ryan J Ollos

Reassigning ticket after changing maintainer of plugin.

comment:3 Changed 7 years ago by Ryan J Ollos

Description: modified (diff)

comment:4 Changed 6 years ago by Ryan J Ollos

Hello,

I took over maintainership of this plugin from athomas some time ago. There is a significant amount of work to do on this plugin, and I don't foresee having the time to do it all.

helend has written the TracSuposePlugin, which seems like a much better solution. Rather than writing the repository search functionality from scratch, a Trac interface to an existing repository search tool has been created. Rather than throwing more effort at this plugin, I'd prefer to help helend with enhancements to the TracSuposePlugin, or spend my time on other Trac plugin projects altogether.

I'd like to get some feedback and hear if anyone knows of a compelling reason to continue this project rather than moving to the TracSuposePlugin. Is there functionality in this plugin that doesn't exist in the TracSuposePlugin? I'm open to hearing all opinions and suggestions.

I'll leave these tickets open for about a week, but in all likelihood will close all of them and deprecate the plugin.

Thanks for your time,

  • Ryan

comment:5 Changed 5 years ago by Ryan J Ollos

Cc: ejucovy added; anonymous removed
Resolution: wontfix
Status: newclosed

Please try MultiRepoSearchPlugin for Trac 0.12 and non-svn repositories.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.