Modify

Opened 8 years ago

Closed 8 years ago

#5618 closed defect (fixed)

Produces invalid URLs

Reported by: lostclus@… Owned by: Edward S. Marshall
Priority: normal Component: TracSitemapPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description

TracSitemap don't use URL quoting. Some special characters and unicode characters must be quoted. For example:

<loc>http://example.org/wiki/Скачать</loc>

should be:

<loc>http://example.org/wiki/%D0%A1%D0%BA%D0%B0%D1%87%D0%B0%D1%82%D1%8C</loc>

Solution: look at the Trac source code and you see that Trac uses special functions to build URLs. This functions knows about all special characters that must be quoted.

Instead of writing:

'wiki/%s' % (row[0],)

write:

req.href('wiki', row[0])

And remember that req.href() adds req.base_path automatically.

Attachments (0)

Change History (1)

comment:1 Changed 8 years ago by Edward S. Marshall

Resolution: fixed
Status: newclosed

Fixed in r7132.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Edward S. Marshall.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.