[Patch] UnicodeDecodeError

[anonymous]

Trac 0.11.5.ja1においては，テンプレート (テンプレート内の位置が特定できません) のレンダリング中に Genshi のエラー UnicodeDecodeError が発生しました。

[Jun Omae]

I use workfloweditorplugin/0.11@6348​ and have a same problem.

In my environment, the problem is fixed by the below patch.

workfloweditor/workfloweditor_admin.py

@@ -116 +116 @@
         # read defalut config
         template = Chrome(self.env).load_template(init_file, 'text')
         stream = template.generate()
-        default_config = stream.render('text')
+        default_config = stream.render('text', encoding=None)
 
         page_param['workflow_default_config'] = default_config
 

[Ryan J Ollos]

#8459 closed as a duplicate.

[Ryan J Ollos]

I'm going to go ahead and apply this patch because I see encoding=None as an argument to render when grepping the Trac codebase, but I'm having trouble reproducing the issue. If someone can send the specific workflow test that reproduces the error, that would be a big help. Please test the latest checkin as well.

[Ryan J Ollos]

(In [9976]) Fixed UnicodeDecode error. Thanks to jun66j5 for the patch. Refs #5901, #8459.

[Ryan J Ollos]

(In [9977]) Merge [9976] into 0.11 branch. Fixes #5901. Refs #8459.

[Jun Omae]

Replying to rjollos:

I'm going to go ahead and apply this patch because I see encoding=None as an argument to render when grepping the Trac codebase, but I'm having trouble reproducing the issue. If someone can send the specific workflow test that reproduces the error, that would be a big help. Please test the latest checkin as well.

I tested the latest with Trac 0.11-stable in Japanese environment and the issue is fixed. Thanks!

BTW, render() method is in genshi.core.Stream class. When encoding=None, the method returns a unicode object.

cf. ​http://genshi.edgewall.org/browser/tags/0.6.0/genshi/core.py#L156