Modify

Opened 14 years ago

Last modified 4 years ago

#6160 new enhancement

TracPastePlugin: Implement TagsPlugin support

Reported by: lkraav Owned by:
Priority: normal Component: TracPastePlugin
Severity: normal Keywords:
Cc: Steffen Hoffmann, Michael Renzmann, ejucovy Trac Release: 0.11

Description

would be nice to be able to tag pastes right? opinions welcome.

Attachments (0)

Change History (13)

comment:1 Changed 14 years ago by Ryan J Ollos

Cc: Ryan J Ollos added; anonymous removed
Summary: implement TagsPlugin supportImplement TagsPlugin support

comment:2 Changed 14 years ago by lkraav

Summary: Implement TagsPlugin supportTracPastePlugin: Implement TagsPlugin support

comment:3 Changed 12 years ago by Ryan J Ollos

Cc: Steffen Hoffmann Michael Renzmann added; Ryan J Ollos removed
Owner: changed from Michael Renzmann to Ryan J Ollos
Status: newassigned

I'll be finishing up implementation of this in the next day or so and will be requesting some feedback on the patch.

comment:4 Changed 12 years ago by Ryan J Ollos

I received an email with:


Comment (by lkraav):

Awesome news. Will you be basing this on top of 0.12 or 1.0?


but the comment seems to have disappeared. I'll answer anyways ;)

I'm developing again 0.11 and when I think the code is ready I test against 0.13dev (i.e. 1.0dev).

comment:5 Changed 12 years ago by lkraav

Yeah, I didn't notice your initial reply was for this particular feature, not the main tracker ticket I was looking at yesterday. So I didn't think my comment made much sense here :> but I guess know we know.

My main concern is the significantly changed DB API for 1.0.

comment:6 in reply to:  5 ; Changed 12 years ago by Ryan J Ollos

Replying to lkraav:

My main concern is the significantly changed DB API for 1.0.

I'm not familiar with the changed API ... I'll have to look into that. And I certainly appreciate code review after I get the feature finished ;)

comment:7 in reply to:  6 Changed 12 years ago by Steffen Hoffmann

Replying to rjollos:

Replying to lkraav:

My main concern is the significantly changed DB API for 1.0.

I've tracked that particular development over the last months. While this is the biggest outside-facing change on the API level for Trac 0.13 aka 1.0 indeed, there is still not much to fear for plugins, since the 0.11 db API is still available. But most probably it will not survive another release cycle.

I plan to create a dedicated 1.0 branch for plugins that I maintain. Switching to the new API is not complicated, but you'll push minimum requirements up to Python2.5 due to use of the ‘with‘ statement, what is not feasible for some of the existing Trac 0.11 installations. So I do - similarly to Ryan - develop at 0.11 and upgrade to 1.0 later.

I'm not familiar with the changed API ... I'll have to look into that. And I certainly appreciate code review after I get the feature finished ;)

Will do a review too, especially appreciate another !ITagProvider implementation. Make sure to drop a hint in the TagsPlugin wiki docs, or I'll do so.

comment:8 in reply to:  5 ; Changed 12 years ago by Ryan J Ollos

Replying to lkraav:

My main concern is the significantly changed DB API for 1.0.

Ticket #7204 may be related to the DB API change.