[Patch] javascript error: /\/ticket\/(\d+)/.exec(document.location) is null

[Vincent]

Hello,

Using TicketDeletePlugin 2.0 with Trac 0.11 with Python 2.4.

It works great but on the page "newticket" of Trac, a javascript error occurs due to TicketDeletePlugin:

Error: /\/ticket\/(\d+)/.exec(document.location) is null
Source File: https://www.myserver.tld/myproject/chrome/ticketdelete/ticketdelete.js
Line: 2

Thats's annoying because it breaks the other javascript running on this page (in particular the ajax stuff of AutocompleteUsersPlugin).

[Carsten]

Same here.

[Jun Omae]

I have got a same problem. In my environment, I applied the following patch that works in the /newticket page.

ticketdelete/htdocs/ticketdelete.js

@@ -1 +1 @@
 $(document).ready(function() {
-    var ticket = /\/ticket\/(\d+)/.exec(document.location)[1];
+    var matched = /\/ticket\/(\d+)/.exec(document.location);
+    if (!matched) {
+        return;
+    }
+    var ticket = matched[1];
     var delete_link = '<a href="../admin/ticket/delete/'+ticket+'">Delete</a>';
     var ticket_buttons = $('#ticket .inlinebuttons')[0];
     if (ticket_buttons) {

[Ryan J Ollos]

The JavaScript is being removed in #1749, which will most likely resolve this issue.