Modify

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#6521 closed enhancement (fixed)

[Patch] Make the control stable while changing month and year, and make the brackets look better

Reported by: Ricky Owned by: anonymous
Priority: normal Component: WikiCalendarMacro
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

  • The formatting of control over month and year looks confusing because the space between the double and single bracket is too small to tell the difference. This patch modifies the CSS part of code to make it look nicer.
  • We certainly don't want the control to move while we change month and year so a small table is created to ensure that.

Attachments (3)

patch.diff (3.3 KB) - added by Ricky 7 years ago.
diff file that shows the code changes
WikiCalendarMacroWith6521Patch.png (51.2 KB) - added by anonymous 7 years ago.
patch2.diff (844 bytes) - added by Ricky 7 years ago.
Fixed the bug: showbutton set to false now displays well

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by Ricky

Attachment: patch.diff added

diff file that shows the code changes

comment:1 Changed 7 years ago by Ryan J Ollos

Summary: make the control stable while changing month and year, and make the brackets look better[Patch] Make the control stable while changing month and year, and make the brackets look better

Thanks for the patch. Let me quickly test and then I will add to the repository.

comment:2 Changed 7 years ago by Ryan J Ollos

Owner: changed from Ryan J Ollos to anonymous
Status: newassigned
Type: defectenhancement

There seems to be an issue with the patch when setting the third argument to false, for example, [[WikiCalendar(2006,07,false)]].

No image "WikiCalendarWith6521Patch.png" attached to Ticket #6521

Changed 7 years ago by anonymous

comment:3 Changed 7 years ago by Ryan J Ollos

Accidentally caught another window when taking the screen capture, but you can see how the calendar is shifted to the right.

Changed 7 years ago by Ricky

Attachment: patch2.diff added

Fixed the bug: showbutton set to false now displays well

comment:4 Changed 7 years ago by Ricky

The bug has been fixed, see attachment.

comment:5 Changed 7 years ago by Ryan J Ollos

Resolution: fixed
Status: assignedclosed

(In [7502]) Applied patch from YouLi to improve positioning of month and year navigation brackets. Fixes #6521

comment:6 Changed 7 years ago by Ryan J Ollos

Thanks for the patch. The improvement is nice. I added you to the Contributor list: WikiCalendarMacro#AuthorContributors

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain anonymous.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.