Modify

Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#6887 closed defect (fixed)

[Patch] WikiCalenderMacro doesn't properly handled urls starting with '/'

Reported by: neil@… Owned by: anonymous
Priority: normal Component: WikiCalendarMacro
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

If an url pattern starting with '/' is used, this isn't properly stripped before the call to has_page, and so the macro never sees that such pages exist.

The attached patch fixes the bug here.

Attachments (1)

WikiCalenderMacro_urls.diff (531 bytes) - added by neil@… 8 years ago.
Patch to strip leading '/'s from the url

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by neil@…

Attachment: WikiCalenderMacro_urls.diff added

Patch to strip leading '/'s from the url

comment:1 Changed 7 years ago by Ryan J Ollos

Thanks for the patch. I will apply it to the trunk tomorrow.

comment:2 Changed 7 years ago by Ryan J Ollos

Owner: changed from Ryan J Ollos to anonymous
Status: newassigned

comment:3 Changed 7 years ago by Ryan J Ollos

Summary: WikiCalenderMacro doesn't properly handled urls starting with '/'[Patch] WikiCalenderMacro doesn't properly handled urls starting with '/'

I will go ahead and apply the patch now, but I won't have time to test. If you are able to test the latest version of the trunk, please report back if you can.

comment:4 Changed 7 years ago by Ryan J Ollos

Resolution: fixed
Status: assignedclosed

(In [7892]) Properly handle URLs that start with . Thanks neil. Fixes #6887.

comment:5 Changed 7 years ago by Ryan J Ollos

Also, please go ahead and list your name in the list of Contributors on the wiki page, if you like.

comment:6 Changed 7 years ago by neil@…

Just tested trunk here - seems to be working fine.

Thanks.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain anonymous.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.